fix: Fixes validator field access for 'project_id' in BigQuery offline Store (feast-dev#4509)

jgesche · tmihalac · commit 993043799cc0 · 2024-09-23T09:51:50.000-04:00
Fixes validator field access for 'billing_project_id' in BigQuery Offline Store

Signed-off-by: gesche &lt;26026582+jgesche@users.noreply.github.com&gt;
diff --git a/sdk/python/feast/infra/offline_stores/bigquery.py b/sdk/python/feast/infra/offline_stores/bigquery.py
@@ -114,7 +114,7 @@ class BigQueryOfflineStoreConfig(FeastConfigBaseModel):
 
     @field_validator("billing_project_id")
     def project_id_exists(cls, v, values, **kwargs):
-        if v and not values["project_id"]:
+        if v and not values.data["project_id"]:
             raise ValueError(
                 "please specify project_id if billing_project_id is specified"
             )

Original file line number	Diff line number	Diff line change
`@@ -114,7 +114,7 @@ class BigQueryOfflineStoreConfig(FeastConfigBaseModel):`
`114`	`114`
`115`	`115`	`@field_validator("billing_project_id")`
`116`	`116`	`def project_id_exists(cls, v, values, **kwargs):`
`117`		`- if v and not values["project_id"]:`
	`117`	`+ if v and not values.data["project_id"]:`
`118`	`118`	`raise ValueError(`
`119`	`119`	`"please specify project_id if billing_project_id is specified"`
`120`	`120`	`)`