Actually allow underscores in incoming service names

jstasiak · jstasiak · commit ae3bd517d84a · 2018-09-21T21:35:55.000+02:00
This was meant to be released earlier, but I failed to merge part of my patch. Fixes: ff4a262 ("Allow underscores in incoming service names") Closes python-zeroconf#102
diff --git a/zeroconf.py b/zeroconf.py
@@ -1270,7 +1270,7 @@ def __init__(self, zc: 'Zeroconf', type_: str, handlers=None, listener=None,
                  addr: str = _MDNS_ADDR, port: int = _MDNS_PORT, delay: int = _BROWSER_TIME) -> None:
         """Creates a browser for a specific type"""
         assert handlers or listener, 'You need to specify at least one handler'
-        if not type_.endswith(service_type_name(type_)):
+        if not type_.endswith(service_type_name(type_, allow_underscores=True)):
             raise BadTypeInNameException
         threading.Thread.__init__(
             self, name='zeroconf-ServiceBrowser_' + type_)
@@ -1403,7 +1403,7 @@ def __init__(self, type_: str, name: str, address: bytes = None, port: int = Non
                     bytes for the text field)
         server: fully qualified name for service host (defaults to name)"""
 
-        if not type_.endswith(service_type_name(name)):
+        if not type_.endswith(service_type_name(name, allow_underscores=True)):
             raise BadTypeInNameException
         self.type = type_
         self.name = name
