Skip to content

Commit 2db0614

Browse files
authored
chore: more comments on GCLOUD_CONFIG (GoogleCloudPlatform#6444)
1 parent e5f8022 commit 2db0614

File tree

3 files changed

+25
-4
lines changed

3 files changed

+25
-4
lines changed

appengine-java11/springboot-helloworld/README.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,11 @@
33
This sample shows how to deploy a [Spring Boot](https://spring.io/projects/spring-boot)
44
application to Google App Engine standard.
55

6+
See the [Quickstart for Java in the App Engine Standard Environment][ae-docs] for more
7+
detailed instructions.
8+
9+
[ae-docs]: https://cloud.google.com/appengine/docs/standard/java11/quickstart
10+
611
## Setup
712

813
See [Prerequisites](../README.md#Prerequisites).

appengine-java11/springboot-helloworld/pom.xml

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -94,8 +94,17 @@
9494
<artifactId>appengine-maven-plugin</artifactId>
9595
<version>2.4.1</version>
9696
<configuration>
97+
<!--
98+
For the details of the parameters, see
99+
https://github.com/GoogleCloudPlatform/app-maven-plugin/blob/master/USER_GUIDE.md
100+
-->
101+
<!-- can be set w/ -Dapp.deploy.version=myProjectId on command line -->
97102
<projectId>GCLOUD_CONFIG</projectId>
98-
<version>springboot-helloworld</version>
103+
<!--
104+
Your application's version in GAE. To use an autogenerated version, use
105+
"GCLOUD_CONFIG" or leave it unspecified.
106+
-->
107+
<version>GCLOUD_CONFIG</version>
99108
</configuration>
100109
</plugin>
101110
</plugins>

appengine-java8/springboot-helloworld/pom.xml

Lines changed: 10 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -93,9 +93,16 @@
9393
<artifactId>appengine-maven-plugin</artifactId>
9494
<version>2.4.1</version>
9595
<configuration>
96-
<!-- can be set w/ -DprojectId=myProjectId on command line -->
97-
<projectId>myProjectId</projectId>
98-
<!-- set the GAE version or use "GCLOUD_CONFIG" for an autogenerated GAE version -->
96+
<!--
97+
For the details of the parameters, see
98+
https://github.com/GoogleCloudPlatform/app-maven-plugin/blob/master/USER_GUIDE.md
99+
-->
100+
<!-- can be set w/ -Dapp.deploy.version=myProjectId on command line -->
101+
<projectId>GCLOUD_CONFIG</projectId>
102+
<!--
103+
Your application's version in GAE. To use an autogenerated version, use
104+
"GCLOUD_CONFIG" or leave it unspecified.
105+
-->
99106
<version>GCLOUD_CONFIG</version>
100107
</configuration>
101108
</plugin>

0 commit comments

Comments
 (0)