Issue jakesgordon#106 - a rejected async lifecycle event should throw an exception

jakesgordon · jakesgordon · commit 186130856cbb · 2017-06-10T14:24:53.000-07:00
diff --git a/src/jsm.js b/src/jsm.js
@@ -108,6 +108,7 @@ mixin(JSM.prototype, {
 
   beginTransit: function()          { this.pending = true;                 },
   endTransit:   function(result)    { this.pending = false; return result; },
+  failTransit:  function(result)    { this.pending = false; throw result;  },
   doTransit:    function(lifecycle) { this.state = lifecycle.to;           },
 
   observe: function(args) {
@@ -153,7 +154,7 @@ mixin(JSM.prototype, {
           result = observer[event].apply(observer, args);
       if (result && typeof result.then === 'function') {
         return result.then(this.observeEvents.bind(this, events, args, event))
-                     .catch(this.endTransit.bind(this))
+                     .catch(this.failTransit.bind(this))
       }
       else if (result === false) {
         return this.endTransit(false);
diff --git a/test/lifecycle.js b/test/lifecycle.js
@@ -587,7 +587,8 @@ test('lifecycle events can be cancelled using a promise', t => {
     }
 
     fsm.step('additional', 'arguments')
-       .then(done)
+       .then(function() { done('promise was rejected so this should never happen'); })
+       .catch(done)
 
   })
 })

Original file line number	Diff line number	Diff line change
`@@ -587,7 +587,8 @@ test('lifecycle events can be cancelled using a promise', t => {`
`587`	`587`	`}`
`588`	`588`
`589`	`589`	`fsm.step('additional', 'arguments')`
`590`		`- .then(done)`
	`590`	`+ .then(function() { done('promise was rejected so this should never happen'); })`
	`591`	`+ .catch(done)`
`591`	`592`
`592`	`593`	`})`
`593`	`594`	`})`