Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: chromiumembedded/java-cef
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: tlappe/java-cef
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: master
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 11 commits
  • 20 files changed
  • 4 contributors

Commits on Oct 24, 2024

  1. Configuration menu
    Copy the full SHA
    7904d8b View commit details
    Browse the repository at this point in the history
  2. Merge remote-tracking branch 'origin/master'

    Tim Lappe committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    ea6df58 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    b48d3df View commit details
    Browse the repository at this point in the history

Commits on Nov 2, 2025

  1. Configuration menu
    Copy the full SHA
    1d90e0f View commit details
    Browse the repository at this point in the history

Commits on Apr 3, 2026

  1. Add CefSSLInfo support, SSL test refactoring, and native binary auto-…

    …download for tests
    
    - Fix CefSSLInfo.statusBiset typo to statusBitset
    - Refactor SelfSignedSSLTest to use named inner classes instead of anonymous
      classes, fixing field access issues with the TestFrame template method pattern
    - Add TestFrame(String startURL) constructor for direct browser URL setup
    - Add automatic native binary download from tlappe/jcefbuild GitHub releases
      via NativesInstaller, integrated into TestSetupExtension using
      SystemBootstrap.setLoader() for absolute path loading
    - Add jcef-natives/ to .gitignore
    
    Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
    Tim Lappe and claude committed Apr 3, 2026
    Configuration menu
    Copy the full SHA
    b3ad0c1 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    60d0350 View commit details
    Browse the repository at this point in the history
  3. Fix DisplayHandlerTest double callback assertion failure

    onTitleChange and onAddressChange can be called multiple times
    (e.g. during browser close). Use an early return guard instead of
    assertFalse to prevent assertion failures on subsequent calls.
    Also fix assertEquals argument order in onAddressChange.
    
    Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
    Tim Lappe and claude committed Apr 3, 2026
    Configuration menu
    Copy the full SHA
    4f1f661 View commit details
    Browse the repository at this point in the history
  4. Fix DragDataTest to use getFilePaths instead of getFileNames

    getFileNames returns display names ("File 1"), not paths.
    The test was verifying paths, so it should use getFilePaths
    which was added in a prior commit (CefDragData.getFilePaths).
    
    Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
    Tim Lappe and claude committed Apr 3, 2026
    Configuration menu
    Copy the full SHA
    da6b86e View commit details
    Browse the repository at this point in the history
  5. Fix SelfSignedSSLTest for CEF 143 (Chromium 143) compatibility

    Chromium 143 treats localhost/loopback and private IPs as
    "potentially trustworthy origins" and silently accepts self-signed
    certificates without calling onCertificateError. Additionally,
    valid self-signed certs (not expired) are accepted on mapped domains.
    
    Changes:
    - Use --host-resolver-rules to map a fictitious domain
      (jcef-test.invalid) to 127.0.0.1, forcing Chromium to treat
      the connection as external
    - Generate an expired self-signed certificate programmatically
      to ensure Chromium triggers onCertificateError
    - Add terminateTest() call in onLoadError for certificateRejected
    - Make sslInfo and boolean flags volatile for cross-thread visibility
    - Bind HTTPS server explicitly to 127.0.0.1 with TLSv1.2
    
    Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
    Tim Lappe and claude committed Apr 3, 2026
    Configuration menu
    Copy the full SHA
    50ce587 View commit details
    Browse the repository at this point in the history
  6. Clean up TestSetupExtension and add CEF host-resolver-rules

    - Remove ProcessEnvironment reflection hack (not needed with JDK in PATH)
    - Keep SystemBootstrap.setLoader for CEF natives (absolute path loading)
    - Add --host-resolver-rules flag to map jcef-test.invalid to 127.0.0.1
      for SSL certificate error testing
    
    Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
    Tim Lappe and claude committed Apr 3, 2026
    Configuration menu
    Copy the full SHA
    61a913f View commit details
    Browse the repository at this point in the history
  7. Simplify SSL tests: remove host-resolver-rules, use localhost

    The root cause of onCertificateError not firing was the old
    JetBrains-generated JKS certificate (valid until 2042) being
    silently accepted by Chromium 143. The programmatically generated
    expired certificate is sufficient to trigger the callback, even
    on localhost. No host-resolver-rules hack needed.
    
    Also removes the unused JKS_BASE64 constant and makeKeyStore method.
    
    Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
    Tim Lappe and claude committed Apr 3, 2026
    Configuration menu
    Copy the full SHA
    3a8c05a View commit details
    Browse the repository at this point in the history
Loading