synthio: shift 19 was too much for a note with amplitude 1

jepler · jepler · commit 8a85deb1e2d7 · 2023-05-30T09:26:14.000-05:00
diff --git a/shared-module/synthio/Biquad.c b/shared-module/synthio/Biquad.c
@@ -94,7 +94,7 @@ mp_obj_t common_hal_synthio_new_bpf(mp_float_t w0, mp_float_t Q) {
     return namedtuple_make_new((const mp_obj_type_t *)&synthio_biquad_type_obj, MP_ARRAY_SIZE(out_args), 0, out_args);
 }
 
-#define BIQUAD_SHIFT (19)
+#define BIQUAD_SHIFT (15)
 STATIC int32_t biquad_scale_arg_obj(mp_obj_t arg) {
     return (int32_t)MICROPY_FLOAT_C_FUN(round)(MICROPY_FLOAT_C_FUN(ldexp)(mp_obj_get_float(arg), BIQUAD_SHIFT));
 }

Original file line number	Diff line number	Diff line change
`@@ -94,7 +94,7 @@ mp_obj_t common_hal_synthio_new_bpf(mp_float_t w0, mp_float_t Q) {`
`94`	`94`	`return namedtuple_make_new((const mp_obj_type_t *)&synthio_biquad_type_obj, MP_ARRAY_SIZE(out_args), 0, out_args);`
`95`	`95`	`}`
`96`	`96`
`97`		`-#define BIQUAD_SHIFT (19)`
	`97`	`+#define BIQUAD_SHIFT (15)`
`98`	`98`	`STATIC int32_t biquad_scale_arg_obj(mp_obj_t arg) {`
`99`	`99`	`return (int32_t)MICROPY_FLOAT_C_FUN(round)(MICROPY_FLOAT_C_FUN(ldexp)(mp_obj_get_float(arg), BIQUAD_SHIFT));`
`100`	`100`	`}`