hd wallet support

sashazykov · sashazykov · commit c4fe2da1ec82 · 2017-03-08T19:48:34.000+03:00
diff --git a/app/models/project.rb b/app/models/project.rb
@@ -1,7 +1,8 @@
 class Project < ActiveRecord::Base
   acts_as_paranoid
 
-  has_many :deposits # todo: only confirmed deposits
+  belongs_to :wallet
+  has_many :deposits # TODO: only confirmed deposits
   has_many :tips, inverse_of: :project
   accepts_nested_attributes_for :tips
   has_many :collaborators, autosave: true
@@ -19,6 +20,8 @@ class Project < ActiveRecord::Base
     end
   end
 
+  after_create :generate_bitcoin_address
+
   # before_save :check_tips_to_pay_against_avaiable_amount
 
   def update_bitcoin_address
@@ -263,4 +266,12 @@ def unarchive_address!
       return nil
     end
   end
+
+  def generate_bitcoin_address
+    wallet = Wallet.order(created_at: :asc).last
+    return unless wallet
+    self.wallet = wallet
+    self.bitcoin_address = wallet.generate_address
+    save
+  end
 end
diff --git a/app/models/wallet.rb b/app/models/wallet.rb
@@ -0,0 +1,21 @@
+class Wallet < ActiveRecord::Base
+
+  validates :name, :xpub, presence: true
+
+  def generate_address
+    address = hd_wallet.node_for_path("0/#{last_address_index}.pub").to_address
+    self.last_address_index += 1
+    save
+    address
+  end
+
+  def address_by_index(index)
+    hd_wallet.node_for_path("0/#{index}.pub").to_address
+  end
+
+  private
+
+  def hd_wallet
+    MoneyTree::Node.from_bip32(xpub)
+  end
+end
diff --git a/db/migrate/20170308152313_create_wallets.rb b/db/migrate/20170308152313_create_wallets.rb
@@ -0,0 +1,11 @@
+class CreateWallets < ActiveRecord::Migration
+  def change
+    create_table :wallets do |t|
+      t.string :name
+      t.string :xpub
+      t.integer :last_address_index, default: 1, limit: 4
+
+      t.timestamps null: false
+    end
+  end
+end
diff --git a/db/migrate/20170308161814_add_wallet_id_to_projects.rb b/db/migrate/20170308161814_add_wallet_id_to_projects.rb
@@ -0,0 +1,5 @@
+class AddWalletIdToProjects < ActiveRecord::Migration
+  def change
+    add_column :projects, :wallet_id, :integer
+  end
+end
diff --git a/db/migrate/20170308163825_add_legacy_addresses_to_projects.rb b/db/migrate/20170308163825_add_legacy_addresses_to_projects.rb
@@ -0,0 +1,5 @@
+class AddLegacyAddressesToProjects < ActiveRecord::Migration
+  def change
+    add_column :projects, :legacy_address, :string
+  end
+end
diff --git a/db/schema.rb b/db/schema.rb
@@ -11,7 +11,7 @@
 #
 # It's strongly recommended that you check this file into your version control system.
 
-ActiveRecord::Schema.define(version: 20151219081507) do
+ActiveRecord::Schema.define(version: 20170308163825) do
 
   create_table "collaborators", force: :cascade do |t|
     t.integer  "project_id"
@@ -56,6 +56,8 @@
     t.string   "avatar_url",             limit: 255
     t.datetime "deleted_at"
     t.string   "bitcoin_address2"
+    t.integer  "wallet_id"
+    t.string   "legacy_address"
   end
 
   add_index "projects", ["full_name"], name: "index_projects_on_full_name", unique: true
@@ -131,4 +133,12 @@
   add_index "users", ["email"], name: "index_users_on_email", unique: true
   add_index "users", ["reset_password_token"], name: "index_users_on_reset_password_token", unique: true
 
+  create_table "wallets", force: :cascade do |t|
+    t.string   "name"
+    t.string   "xpub"
+    t.integer  "last_address_index", limit: 4, default: 1
+    t.datetime "created_at",                               null: false
+    t.datetime "updated_at",                               null: false
+  end
+
 end
diff --git a/spec/factories/project.rb b/spec/factories/project.rb
@@ -3,7 +3,6 @@
     url "MyString"
     full_name "test/test"
     github_id "1234567890"
-    bitcoin_address "bitcoin_address"
 
     trait :github do
       host 'github'
diff --git a/spec/factories/wallets.rb b/spec/factories/wallets.rb
@@ -0,0 +1,7 @@
+FactoryGirl.define do
+  factory :wallet do
+    name 'test wallet'
+    xpub 'xpub661MyMwAqRbcFepxYZyGLKMTkTPDvbfLaoYDbw4d4iQT5SycGiJQREuraJ2N6Uh' \
+         'LGPcjXDhnARdtcUhgqN3a2dgQ3Dx8u1chtk8Rx16LrWg'
+  end
+end
diff --git a/spec/models/deposit_spec.rb b/spec/models/deposit_spec.rb
@@ -1,6 +1,6 @@
 require 'spec_helper'
 
-describe Deposit do
+describe Deposit, type: :model do
   let(:deposit) { create(:deposit) }
 
   describe 'Associations' do
@@ -36,4 +36,4 @@ def with_custom_fee
     CONFIG["our_fee"] = old_fee
   end
 
-end
+end
diff --git a/spec/models/project_spec.rb b/spec/models/project_spec.rb
@@ -1,12 +1,13 @@
 require 'spec_helper'
 
-describe Project do
+describe Project, type: :model do
   let(:project) { create(:project) }
   let(:project_of_bitbucket) { create(:project, :bitbucket) }
 
   describe 'Associations' do
     it { should have_many(:deposits) }
     it { should have_many(:tips) }
+    it { should belong_to(:wallet) }
   end
 
   describe 'Validations' do
@@ -18,6 +19,27 @@
     it { should ensure_inclusion_of(:host).in_array([ "github", "bitbucket" ]) }
   end
 
+  describe 'bitcoin_address' do
+    let(:wallet) { create(:wallet) }
+
+    before do
+      create(:wallet, xpub: 'xpub1key')
+      wallet
+    end
+
+    it 'should generate a bitcoin address' do
+      expect(project.bitcoin_address).not_to be_blank
+    end
+
+    it 'should connect project to the last wallet' do
+      expect(project.wallet).to eq wallet
+    end
+
+    it 'should increment wallet\'s last_address_index' do
+      expect { project }.to change { wallet.reload.last_address_index }.by 1
+    end
+  end
+
   describe '#repository_client' do
     context 'when host is github' do
       it 'returns Github instance' do
diff --git a/spec/models/user_spec.rb b/spec/models/user_spec.rb
@@ -1,6 +1,6 @@
 require 'spec_helper'
 
-describe User do
+describe User, type: :model do
   let(:user) { create(:user) }
 
   describe 'full_name' do
diff --git a/spec/models/wallet_spec.rb b/spec/models/wallet_spec.rb
@@ -0,0 +1,21 @@
+require 'spec_helper'
+
+describe Wallet, type: :model do
+  let(:wallet) { create(:wallet) }
+  describe 'Validations' do
+    it { should validate_presence_of(:name) }
+    it { should validate_presence_of(:xpub) }
+  end
+
+  describe '#generate_address' do
+    subject { wallet.generate_address }
+
+    it 'should return a new address' do
+      expect(subject).to eq '125q4q36PT2gGoeNWXm34RepMcgghLghiZ'
+    end
+
+    it 'should increment last_address_index' do
+      expect { subject }.to change { wallet.reload.last_address_index }.by 1
+    end
+  end
+end
