ref: Update mypy

untitaker · untitaker · commit b35fa6b33bad · 2019-10-17T19:23:26.000+02:00
diff --git a/sentry_sdk/integrations/flask.py b/sentry_sdk/integrations/flask.py
@@ -134,11 +134,11 @@ def raw_data(self):
         return self.request.get_data()
 
     def form(self):
-        # type: () -> ImmutableMultiDict
+        # type: () -> ImmutableMultiDict[str, Any]
         return self.request.form
 
     def files(self):
-        # type: () -> ImmutableMultiDict
+        # type: () -> ImmutableMultiDict[str, Any]
         return self.request.files
 
     def is_json(self):
diff --git a/sentry_sdk/integrations/redis.py b/sentry_sdk/integrations/redis.py
@@ -49,5 +49,5 @@ def sentry_patched_execute_command(self, name, *args, **kwargs):
                 return old_execute_command(self, name, *args, **kwargs)
 
         redis.StrictRedis.execute_command = (  # type: ignore
-            sentry_patched_execute_command
+            sentry_patched_execute_command  # type: ignore
         )
diff --git a/sentry_sdk/utils.py b/sentry_sdk/utils.py
@@ -104,16 +104,25 @@ def __init__(self, value):
             self.__dict__ = dict(value.__dict__)
             return
         parts = urlparse.urlsplit(text_type(value))
+
         if parts.scheme not in (u"http", u"https"):
             raise BadDsn("Unsupported scheme %r" % parts.scheme)
         self.scheme = parts.scheme
+
+        if parts.hostname is None:
+            raise BadDsn("Missing hostname")
+
         self.host = parts.hostname
-        self.port = parts.port
-        if self.port is None:
+
+        if parts.port is None:
             self.port = self.scheme == "https" and 443 or 80
-        self.public_key = parts.username
-        if not self.public_key:
+        else:
+            self.port = parts.port
+
+        if not parts.username:
             raise BadDsn("Missing public key")
+
+        self.public_key = parts.username
         self.secret_key = parts.password
 
         path = parts.path.rsplit("/", 1)
diff --git a/tox.ini b/tox.ini
@@ -159,7 +159,7 @@ deps =
     linters: black
     linters: flake8
     linters: flake8-import-order
-    linters: mypy==0.730
+    linters: mypy==0.740
     linters: flake8-bugbear>=19.8.0
 
     py3.8: hypothesis

Original file line number	Diff line number	Diff line change
`@@ -49,5 +49,5 @@ def sentry_patched_execute_command(self, name, args, *kwargs):`
`49`	`49`	`return old_execute_command(self, name, args, *kwargs)`
`50`	`50`
`51`	`51`	`redis.StrictRedis.execute_command = ( # type: ignore`
`52`		`- sentry_patched_execute_command`
	`52`	`+ sentry_patched_execute_command # type: ignore`
`53`	`53`	`)`