fix: Do not persist httplib response in breadcrumbs

untitaker · untitaker · commit 057b13640df5 · 2019-09-05T11:33:36.000+02:00
diff --git a/sentry_sdk/tracing.py b/sentry_sdk/tracing.py
@@ -402,13 +402,13 @@ def _maybe_create_breadcrumbs_from_span(hub, span):
             type="http",
             category="httplib",
             data=span._data,
-            hint={"httplib_response": span._data.get("httplib_response")},
+            hint={"httplib_response": span._data.pop("httplib_response", None)},
         )
     elif span.op == "subprocess":
         hub.add_breadcrumb(
             type="subprocess",
             category="subprocess",
             message=span.description,
             data=span._data,
-            hint={"popen_instance": span._data.get("popen_instance")},
+            hint={"popen_instance": span._data.pop("popen_instance", None)},
         )
diff --git a/tests/integrations/stdlib/test_httplib.py b/tests/integrations/stdlib/test_httplib.py
@@ -1,3 +1,4 @@
+import sys
 import pytest
 
 try:
@@ -32,7 +33,6 @@ def test_crumb_capture(sentry_init, capture_events):
         "method": "GET",
         "status_code": 200,
         "reason": "OK",
-        "httplib_response": crumb["data"]["httplib_response"],
     }
 
 
@@ -62,9 +62,10 @@ def before_breadcrumb(crumb, hint):
         "status_code": 200,
         "reason": "OK",
         "extra": "foo",
-        "httplib_response": crumb["data"]["httplib_response"],
     }
 
+    assert sys.getrefcount(response) == 2
+
 
 def test_httplib_misuse(sentry_init, capture_events):
     """HTTPConnection.getresponse must be called after every call to
@@ -104,5 +105,4 @@ def test_httplib_misuse(sentry_init, capture_events):
         "method": "GET",
         "status_code": 200,
         "reason": "OK",
-        "httplib_response": crumb["data"]["httplib_response"],
     }
