test(rate-limit): add tests to improve coverage

v1rtl · claude · v1rtl · commit 34c5dcce98c6 · 2026-02-01T10:20:40.000+02:00
Add tests covering:
- max as an async function
- Successful requests with skipFailedRequests (no decrement)
- Failed requests with skipSuccessfulRequests (no decrement)
- onLimitReached callback when limit is first reached
- Store error in incr callback
- headers: false option when rate limited

Improves rate-limit.ts coverage:
- Statements: 95% -&gt; 97%
- Branches: 83% -&gt; 94%

Co-Authored-By: Claude Opus 4.5 &lt;noreply@anthropic.com&gt;
diff --git a/tests/wares/rate-limit/rate-limit.test.ts b/tests/wares/rate-limit/rate-limit.test.ts
@@ -234,6 +234,101 @@ describe('rate-limit', () => {
 
       expect(shouldSkip).toHaveBeenCalled()
     })
+
+    it('should support max as an async function', async () => {
+      const maxFn = vi.fn(async () => 2)
+
+      const app = createAppWith(
+        rateLimit({
+          max: maxFn
+        })
+      )
+
+      await makeFetch(app)('/').expect(200)
+      await makeFetch(app)('/').expect(200)
+      await makeFetch(app)('/').expect(429)
+
+      expect(maxFn).toHaveBeenCalled()
+    })
+
+    it('should not decrement on successful requests when skipFailedRequests is true', async () => {
+      const store = new MockStore()
+      const app = createAppWith(
+        rateLimit({
+          skipFailedRequests: true,
+          store: store
+        })
+      )
+
+      await makeFetch(app)('/').expect(200)
+      // decrement should NOT be called for successful requests with skipFailedRequests
+      expect(store.decrement_was_called).toBeFalsy()
+    })
+
+    it('should not decrement on failed requests when skipSuccessfulRequests is true', async () => {
+      const store = new MockStore()
+      const app = createAppWith(
+        rateLimit({
+          skipSuccessfulRequests: true,
+          store: store
+        })
+      )
+
+      await makeFetch(app)('/errorPage').expect(404)
+      // decrement should NOT be called for failed requests with skipSuccessfulRequests
+      expect(store.decrement_was_called).toBeFalsy()
+    })
+
+    it('should call onLimitReached when limit is first reached', async () => {
+      const onLimitReached = vi.fn()
+
+      const app = createAppWith(
+        rateLimit({
+          max: 1,
+          onLimitReached
+        })
+      )
+
+      await makeFetch(app)('/').expect(200)
+      expect(onLimitReached).not.toHaveBeenCalled()
+
+      await makeFetch(app)('/').expect(429)
+      expect(onLimitReached).toHaveBeenCalledTimes(1)
+
+      // Should not call again on subsequent requests
+      await makeFetch(app)('/').expect(429)
+      expect(onLimitReached).toHaveBeenCalledTimes(1)
+    })
+
+    it('should handle store error in incr callback', async () => {
+      const errorStore = {
+        incr: (_, cb) => {
+          cb(new Error('Store error'), 0, new Date())
+        },
+        resetKey: () => {},
+        decrement: () => {},
+        resetAll: () => {}
+      }
+
+      const app = createAppWith(
+        rateLimit({
+          store: errorStore
+        })
+      )
+
+      await makeFetch(app)('/').expect(500)
+    })
+
+    it('should not send headers when headers option is false and rate limited', async () => {
+      const app = new App()
+      app.use(rateLimit({ max: 1, headers: false }))
+      app.get('/', (_, res) => res.send('response!'))
+      const server = app.listen()
+
+      await makeFetch(server)('/').expect(200)
+      const response = await makeFetch(server)('/').expect(429)
+      expect(response.headers.get('retry-after')).toBeNull()
+    })
   })
 })
 
