Skip to content

Commit feea0cc

Browse files
committed
update tests:
- {'is_empty': True} -> None - fill is specs with None after colspans
1 parent f0c3997 commit feea0cc

1 file changed

Lines changed: 10 additions & 6 deletions

File tree

plotly/tests/test_core/test_tools/test_get_subplots.py

Lines changed: 10 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -687,7 +687,9 @@ def test_subplot_specs():
687687
)
688688
)
689689

690-
fig = tls.get_subplots(rows=2, columns=3, specs=[[{}], [{}, {}, {}]])
690+
fig = tls.get_subplots(rows=2, columns=3,
691+
specs=[[{}, None, None],
692+
[{}, {}, {}]])
691693

692694
assert fig == expected
693695

@@ -739,7 +741,7 @@ def test_subplot_specs_colspan():
739741
)
740742

741743
fig = tls.get_subplots(rows=3, columns=2,
742-
specs=[[{'colspan':2}],
744+
specs=[[{'colspan':2}, None],
743745
[{}, {}],
744746
[{}, {}]])
745747
assert fig == expected
@@ -801,8 +803,8 @@ def test_subplot_specs_rowspan():
801803

802804
fig = tls.get_subplots(rows=3, columns=3,
803805
specs=[[{'rowspan': 3}, {}, {}],
804-
[{'is_empty': True}, {}, {}],
805-
[{'is_empty': True}, {'colspan': 2}]])
806+
[None, {}, {}],
807+
[None, {'colspan': 2}, None]])
806808

807809
assert fig == expected
808810

@@ -855,8 +857,10 @@ def test_subplot_specs_rowspan2():
855857

856858
fig = tls.get_subplots(rows=3, columns=3,
857859
specs=[[{}, {}, {'rowspan': 2}],
858-
[{'colspan': 2}],
859-
[{'colspan': 3}]])
860+
[{'colspan': 2}, None, None],
861+
[{'colspan': 3}, None, None]])
862+
863+
assert fig == expected
860864

861865
assert fig == expected
862866

0 commit comments

Comments
 (0)