Skip to content

Commit 1fe7cf7

Browse files
committed
python3Packages.exceptiongroup: update repr patch after 3.14 backport
[1] was finally backported to CPython 3.14 in [2], which landed in CPython 3.14.4, causing the build of `python314Packages.exceptiongroup` to fail. In the meantime, exceptiongroup fixed `BaseExceptionGroup.__repr__` on their end to match CPython behavior [3], so we can use that patch instead. [1] python/cpython#141736 [2] python/cpython#144445 [3] agronholm/exceptiongroup#155
1 parent eeadbd1 commit 1fe7cf7

1 file changed

Lines changed: 14 additions & 9 deletions

File tree

  • pkgs/development/python-modules/exceptiongroup

pkgs/development/python-modules/exceptiongroup/default.nix

Lines changed: 14 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -2,11 +2,11 @@
22
lib,
33
buildPythonPackage,
44
fetchFromGitHub,
5+
fetchpatch,
56
flit-scm,
67
pytestCheckHook,
78
pythonAtLeast,
89
pythonOlder,
9-
isPy313,
1010
typing-extensions,
1111
}:
1212

@@ -22,14 +22,19 @@ buildPythonPackage rec {
2222
hash = "sha256-3WInufN+Pp6vB/Gik6e8V1a34Dr/oiH3wDMB+2lHRMM=";
2323
};
2424

25-
# CPython fixed https://github.com/python/cpython/issues/141732 in
26-
# https://github.com/python/cpython/pull/141736, but exceptiongroup 1.3.1,
27-
# including its test suite, still matches the old repr behavior.
28-
# The CPython fix has only been backported to 3.13 so far, where it was
29-
# first included in version 3.13.12, so we only need to patch for 3.13
30-
# and 3.15+.
31-
# Upstream issue: https://github.com/agronholm/exceptiongroup/issues/154
32-
patches = lib.optional (isPy313 || pythonAtLeast "3.15") ./match-repr-fix.patch;
25+
patches = [
26+
# CPython fixed https://github.com/python/cpython/issues/141732 in
27+
# https://github.com/python/cpython/pull/141736 (backported to Python 3.13+),
28+
# but exceptiongroup 1.3.1, including its test suite, still matches the old
29+
# repr behavior.
30+
# Upstream issue: https://github.com/agronholm/exceptiongroup/issues/154
31+
# Upstream PR: https://github.com/agronholm/exceptiongroup/pull/155
32+
(fetchpatch {
33+
name = "match-repr-fix.patch";
34+
url = "https://github.com/agronholm/exceptiongroup/commit/0c6cfbf677f6b50df17311cfdad01e9ff17310aa.patch";
35+
hash = "sha256-EeYu1/JKYRDwdq8+n38RrdogipNzX0ate1trDs1Z3c0=";
36+
})
37+
];
3338

3439
build-system = [ flit-scm ];
3540

0 commit comments

Comments
 (0)