Skip to content

Commit d0d736e

Browse files
bshafferdwsupplee
authored andcommitted
adds service and version to exception handling (googleapis#689)
* adds service and version to exception handling * fixes BootstrapTest
1 parent 359f2d5 commit d0d736e

2 files changed

Lines changed: 18 additions & 2 deletions

File tree

‎src/ErrorReporting/Bootstrap.php‎

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -117,7 +117,14 @@ public static function exceptionHandler($ex)
117117
{
118118
$message = sprintf('PHP Notice: %s', (string)$ex);
119119
if (self::$psrLogger) {
120-
self::$psrLogger->error($message);
120+
$service = self::$psrLogger->getMetadataProvider()->serviceId();
121+
$version = self::$psrLogger->getMetadataProvider()->versionId();
122+
self::$psrLogger->error($message, [
123+
'serviceContext' => [
124+
'service' => $service,
125+
'version' => $version,
126+
]
127+
]);
121128
} else {
122129
fwrite(STDERR, $message . PHP_EOL);
123130
}

‎tests/unit/ErrorReporting/BootstrapTest.php‎

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -104,8 +104,17 @@ public function testExceptionHandler(
104104
$exception
105105
) {
106106
$expectedMessage = sprintf('PHP Notice: %s', (string)$exception);
107-
$this->psrBatchLogger->error($expectedMessage)
107+
$expectedContext = [
108+
'serviceContext' => [
109+
'service' => '',
110+
'version' => ''
111+
]
112+
];
113+
$this->psrBatchLogger->error($expectedMessage, $expectedContext)
108114
->shouldBeCalledTimes(1);
115+
$this->psrBatchLogger->getMetadataProvider()
116+
->willReturn(new SimpleMetadataProvider())
117+
->shouldBeCalledTimes(2);
109118
Bootstrap::$psrLogger = $this->psrBatchLogger->reveal();
110119
Bootstrap::exceptionHandler($exception);
111120
}

0 commit comments

Comments
 (0)