Skip to content

Commit d242f45

Browse files
committed
upgrade ServiceBuilder to check apiKey preconditions compile-tim (not run-time)
1 parent 30824b3 commit d242f45

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

54 files changed

+76
-117
lines changed

changelog

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
[SNAPSHOT]
22
* LinkedIn use Header to sign OAuth2 requests
3+
* upgrade ServiceBuilder to check apiKey preconditions compile-tim (not run-time)
34

45
[4.1.1]
56
* omit the client_secret parameter if it is an empty string while refreshing token (thanks to https://github.com/KungfuPancake)

scribejava-apis/src/test/java/com/github/scribejava/apis/examples/AWeberExample.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,8 +24,7 @@ private AWeberExample() {
2424
}
2525

2626
public static void main(String... args) throws IOException, InterruptedException, ExecutionException {
27-
final OAuth10aService service = new ServiceBuilder()
28-
.apiKey(CONSUMER_KEY)
27+
final OAuth10aService service = new ServiceBuilder(CONSUMER_KEY)
2928
.apiSecret(CONSUMER_SECRET)
3029
.build(AWeberApi.instance());
3130

scribejava-apis/src/test/java/com/github/scribejava/apis/examples/Box20Example.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,8 +27,7 @@ public static void main(String... args) throws IOException, InterruptedException
2727
final String clientId = "your client id";
2828
final String clientSecret = "your client secret";
2929
final String secretState = "security_token" + new Random().nextInt(999_999);
30-
final OAuth20Service service = new ServiceBuilder()
31-
.apiKey(clientId)
30+
final OAuth20Service service = new ServiceBuilder(clientId)
3231
.apiSecret(clientSecret)
3332
.state(secretState)
3433
.callback("https://example.com/callback")

scribejava-apis/src/test/java/com/github/scribejava/apis/examples/DiggExample.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,8 +24,7 @@ public static void main(String... args) throws IOException, InterruptedException
2424
// Replace these with your own api key and secret
2525
final String apiKey = "myKey";
2626
final String apiSecret = "mySecret";
27-
final OAuth10aService service = new ServiceBuilder()
28-
.apiKey(apiKey)
27+
final OAuth10aService service = new ServiceBuilder(apiKey)
2928
.apiSecret(apiSecret)
3029
.build(DiggApi.instance());
3130
final Scanner in = new Scanner(System.in);

scribejava-apis/src/test/java/com/github/scribejava/apis/examples/FacebookAsyncNingExample.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,8 +35,7 @@ public static void main(String... args) throws InterruptedException, ExecutionEx
3535
.setReadTimeout(1_000)
3636
.build());
3737

38-
try (OAuth20Service service = new ServiceBuilder()
39-
.apiKey(clientId)
38+
try (OAuth20Service service = new ServiceBuilder(clientId)
4039
.apiSecret(clientSecret)
4140
.state(secretState)
4241
.callback("http://www.example.com/oauth_callback/")

scribejava-apis/src/test/java/com/github/scribejava/apis/examples/FacebookExample.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,8 +25,7 @@ public static void main(String... args) throws IOException, InterruptedException
2525
final String clientId = "your client id";
2626
final String clientSecret = "your client secret";
2727
final String secretState = "secret" + new Random().nextInt(999_999);
28-
final OAuth20Service service = new ServiceBuilder()
29-
.apiKey(clientId)
28+
final OAuth20Service service = new ServiceBuilder(clientId)
3029
.apiSecret(clientSecret)
3130
.state(secretState)
3231
.callback("http://www.example.com/oauth_callback/")

scribejava-apis/src/test/java/com/github/scribejava/apis/examples/FlickrExample.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,8 +25,7 @@ public static void main(String... args) throws IOException, InterruptedException
2525
final String apiKey = "your_app_id";
2626
final String apiSecret = "your_api_secret";
2727

28-
final OAuth10aService service = new ServiceBuilder()
29-
.apiKey(apiKey)
28+
final OAuth10aService service = new ServiceBuilder(apiKey)
3029
.apiSecret(apiSecret)
3130
.build(FlickrApi.instance(FlickrApi.FlickrPerm.DELETE));
3231
final Scanner in = new Scanner(System.in);

scribejava-apis/src/test/java/com/github/scribejava/apis/examples/Foursquare2Example.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,8 +23,7 @@ public static void main(String... args) throws IOException, InterruptedException
2323
// Replace these with your own api key and secret
2424
final String apiKey = "your client id";
2525
final String apiSecret = "your client secret";
26-
final OAuth20Service service = new ServiceBuilder()
27-
.apiKey(apiKey)
26+
final OAuth20Service service = new ServiceBuilder(apiKey)
2827
.apiSecret(apiSecret)
2928
.callback("http://localhost:9000/")
3029
.build(Foursquare2Api.instance());

scribejava-apis/src/test/java/com/github/scribejava/apis/examples/FoursquareExample.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,8 +20,7 @@ private FoursquareExample() {
2020
}
2121

2222
public static void main(String... args) throws IOException, InterruptedException, ExecutionException {
23-
final OAuth10aService service = new ServiceBuilder()
24-
.apiKey("your client id")
23+
final OAuth10aService service = new ServiceBuilder("your client id")
2524
.apiSecret("your client secret")
2625
.build(FoursquareApi.instance());
2726
final Scanner in = new Scanner(System.in);

scribejava-apis/src/test/java/com/github/scribejava/apis/examples/FreelancerExample.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,8 +24,7 @@ private FreelancerExample() {
2424
}
2525

2626
public static void main(String... args) throws IOException, InterruptedException, ExecutionException {
27-
final OAuth10aService service = new ServiceBuilder()
28-
.apiKey("your client id")
27+
final OAuth10aService service = new ServiceBuilder("your client id")
2928
.apiSecret("your client secret")
3029
.scope(SCOPE)
3130
.build(FreelancerApi.Sandbox.instance());

0 commit comments

Comments
 (0)