Fix defect in __ixor__ which would get the wrong

raymond.hettinger · raymond.hettinger · commit a3ecfb276a91 · 2008-01-31T01:38:15.000Z
answer if the input iterable had a duplicate element (two calls to toggle() reverse each other). Borrow the correct code from sets.py. git-svn-id: http://svn.python.org/projects/python/trunk@60469 6015fed2-1504-0410-9fe1-9d1591cc4771
diff --git a/Lib/_abcoll.py b/Lib/_abcoll.py
@@ -266,16 +266,6 @@ def pop(self):
         self.discard(value)
         return value
 
-    def toggle(self, value):
-        """Return True if it was added, False if deleted."""
-        # XXX This implementation is not thread-safe
-        if value in self:
-            self.discard(value)
-            return False
-        else:
-            self.add(value)
-            return True
-
     def clear(self):
         """This is slow (creates N new iterators!) but effective."""
         try:
@@ -296,10 +286,13 @@ def __iand__(self, c):
         return self
 
     def __ixor__(self, it):
-        # This calls toggle(), so if that is overridded, we call the override
+        if not isinstance(it, Set):
+            it = self._from_iterable(it)
         for value in it:
-            self.toggle(it)
-        return self
+            if value in self:
+                self.discard(value)
+            else:
+                self.add(value)
 
     def __isub__(self, it):
         for value in it:
