Make utility classes final

pvorb · pvorb · commit bd1c19c36eeb · 2016-08-19T22:03:01.000+02:00
diff --git a/gui/src/main/java/de/vorb/tesseract/gui/io/BoxFileReader.java b/gui/src/main/java/de/vorb/tesseract/gui/io/BoxFileReader.java
@@ -11,7 +11,9 @@
 import java.util.LinkedList;
 import java.util.List;
 
-public class BoxFileReader {
+public final class BoxFileReader {
+
+    private BoxFileReader() {}
 
     public static List<Symbol> readBoxFile(Path boxFile, int pageHeight)
             throws IOException {
diff --git a/gui/src/main/java/de/vorb/tesseract/gui/io/BoxFileWriter.java b/gui/src/main/java/de/vorb/tesseract/gui/io/BoxFileWriter.java
@@ -9,7 +9,10 @@
 import java.nio.charset.StandardCharsets;
 import java.nio.file.Files;
 
-public class BoxFileWriter {
+public final class BoxFileWriter {
+
+    private BoxFileWriter() {}
+
     public static void writeBoxFile(BoxFileModel model) throws IOException {
         final BufferedWriter boxFileWriter = Files.newBufferedWriter(
                 model.getFile(), StandardCharsets.UTF_8);
diff --git a/gui/src/main/java/de/vorb/tesseract/gui/util/DocumentWriter.java b/gui/src/main/java/de/vorb/tesseract/gui/util/DocumentWriter.java
@@ -17,7 +17,10 @@
 import java.nio.file.Files;
 import java.nio.file.Path;
 
-public class DocumentWriter {
+public final class DocumentWriter {
+
+    private DocumentWriter() {}
+
     private static Transformer transformer;
 
     static {
diff --git a/gui/src/main/java/de/vorb/tesseract/gui/util/Resources.java b/gui/src/main/java/de/vorb/tesseract/gui/util/Resources.java
@@ -3,8 +3,11 @@
 import javax.swing.Icon;
 import javax.swing.ImageIcon;
 
-public class Resources {
-    public static final Icon getIcon(String name) {
+public final class Resources {
+
+    private Resources() {}
+
+    public static Icon getIcon(String name) {
         return new ImageIcon(Resources.class.getResource(String.format("/icons/%s.png", name)));
     }
 }
diff --git a/gui/src/main/java/de/vorb/tesseract/gui/view/Colors.java b/gui/src/main/java/de/vorb/tesseract/gui/view/Colors.java
@@ -2,9 +2,9 @@
 
 import java.awt.Color;
 
-public class Colors {
-    private Colors() {
-    }
+public final class Colors {
+
+    private Colors() {}
 
     public static final Color NORMAL = new Color(0xCC0000FF, true);
     public static final Color SELECTION = new Color(0xCCFF0000, true);
diff --git a/gui/src/main/java/de/vorb/tesseract/gui/view/Strokes.java b/gui/src/main/java/de/vorb/tesseract/gui/view/Strokes.java
@@ -3,9 +3,9 @@
 import java.awt.BasicStroke;
 import java.awt.Stroke;
 
-public class Strokes {
-    private Strokes() {
-    }
+public final class Strokes {
+
+    private Strokes() {}
 
     public static final Stroke NORMAL = new BasicStroke(1f);
     public static final Stroke SELECTION = new BasicStroke(1f);
diff --git a/gui/src/main/java/de/vorb/tesseract/gui/view/dialogs/Dialogs.java b/gui/src/main/java/de/vorb/tesseract/gui/view/dialogs/Dialogs.java
@@ -3,7 +3,10 @@
 import javax.swing.JOptionPane;
 import java.awt.Component;
 
-public class Dialogs {
+public final class Dialogs {
+
+    private Dialogs() {}
+
     public static void showInfo(Component parent, String title,
             String message) {
         JOptionPane.showMessageDialog(parent, message, title,
diff --git a/gui/src/main/java/de/vorb/tesseract/gui/view/i18n/Labels.java b/gui/src/main/java/de/vorb/tesseract/gui/view/i18n/Labels.java
@@ -4,7 +4,10 @@
 import java.util.MissingResourceException;
 import java.util.ResourceBundle;
 
-public class Labels {
+public final class Labels {
+
+    private Labels() {}
+
     public static String getLabel(Locale locale, String key) {
         final ResourceBundle labels = ResourceBundle.getBundle("l10n/labels",
                 locale);
diff --git a/tools/src/main/java/de/vorb/tesseract/img/BinaryImage.java b/tools/src/main/java/de/vorb/tesseract/img/BinaryImage.java
@@ -2,7 +2,10 @@
 
 import java.awt.image.BufferedImage;
 
-public class BinaryImage {
+public final class BinaryImage {
+
+    private BinaryImage() {}
+
     /**
      * Require <code>img</code> to be a binary (monochrome) image.
      *
diff --git a/tools/src/main/java/de/vorb/tesseract/tools/preprocessing/binarization/BinarizationUtilities.java b/tools/src/main/java/de/vorb/tesseract/tools/preprocessing/binarization/BinarizationUtilities.java
@@ -4,7 +4,10 @@
 import java.awt.image.BufferedImage;
 import java.awt.image.ColorConvertOp;
 
-public class BinarizationUtilities {
+public final class BinarizationUtilities {
+
+    private BinarizationUtilities() {}
+
     private static final ColorConvertOp RGB_TO_GRAYSCALE = new ColorConvertOp(
             ColorSpace.getInstance(ColorSpace.CS_sRGB),
             ColorSpace.getInstance(ColorSpace.CS_GRAY), null);
diff --git a/tools/src/main/java/de/vorb/tesseract/tools/training/BoxFiles.java b/tools/src/main/java/de/vorb/tesseract/tools/training/BoxFiles.java
@@ -22,9 +22,9 @@
  *
  * @author Paul Vorbach
  */
-public class BoxFiles {
-    private BoxFiles() {
-    }
+public final class BoxFiles {
+
+    private BoxFiles() {}
 
     /**
      * Writes a single page to the given Writer in the box file format.
diff --git a/tools/src/main/java/de/vorb/tesseract/tools/training/ShapeClustering.java b/tools/src/main/java/de/vorb/tesseract/tools/training/ShapeClustering.java
diff --git a/tools/src/main/java/de/vorb/tesseract/tools/training/ShapeTable.java b/tools/src/main/java/de/vorb/tesseract/tools/training/ShapeTable.java
diff --git a/tools/src/main/java/de/vorb/tesseract/tools/training/TessdataManager.java b/tools/src/main/java/de/vorb/tesseract/tools/training/TessdataManager.java
@@ -5,6 +5,9 @@
 import java.nio.file.Path;
 
 public class TessdataManager {
+
+    private TessdataManager() {}
+
     private static final String COMMAND = "combine_tessdata";
 
     public static void extract(Path tessdataFile, Path pathPrefix)
diff --git a/tools/src/main/java/de/vorb/tesseract/tools/visualization/PrototypeRenderer.java b/tools/src/main/java/de/vorb/tesseract/tools/visualization/PrototypeRenderer.java
diff --git a/tools/src/main/java/de/vorb/tesseract/util/TrainingFiles.java b/tools/src/main/java/de/vorb/tesseract/util/TrainingFiles.java
@@ -8,7 +8,7 @@
 import java.util.LinkedList;
 import java.util.List;
 
-public class TrainingFiles {
+public final class TrainingFiles {
     private TrainingFiles() {
     }
 
diff --git a/tools/src/main/java/de/vorb/util/FileIO.java b/tools/src/main/java/de/vorb/util/FileIO.java
diff --git a/tools/src/main/java/de/vorb/util/FileNames.java b/tools/src/main/java/de/vorb/util/FileNames.java
@@ -3,7 +3,10 @@
 import java.nio.file.Path;
 import java.nio.file.Paths;
 
-public class FileNames {
+public final class FileNames {
+
+    private FileNames() {}
+
     public static Path replaceExtension(Path file, String newExtension) {
         final String fname = file.getFileName().toString();
         final int lastDot = fname.lastIndexOf('.');

Original file line number	Diff line number	Diff line change
`@@ -3,8 +3,11 @@`
`3`	`3`	`import javax.swing.Icon;`
`4`	`4`	`import javax.swing.ImageIcon;`
`5`	`5`
`6`		`-public class Resources {`
`7`		`- public static final Icon getIcon(String name) {`
	`6`	`+public final class Resources {`
	`7`	`+`
	`8`	`+ private Resources() {}`
	`9`	`+`
	`10`	`+ public static Icon getIcon(String name) {`
`8`	`11`	`return new ImageIcon(Resources.class.getResource(String.format("/icons/%s.png", name)));`
`9`	`12`	`}`
`10`	`13`	`}`