Skip to content

Commit 80b1292

Browse files
youknowonegithub-actions[bot]
authored and
terryluan12
committed
Replace CallMethod/LoadMethod opcodes with plain Call (RustPython#6674)
* implementing call the correct way stack is [Option<PyObjectRef>] * fix again * list custom instructions * Auto-format: cargo fmt --all --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
1 parent b9a1554 commit 80b1292

9 files changed

Lines changed: 489 additions & 351 deletions

File tree

‎Lib/_opcode_metadata.py‎

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -132,9 +132,6 @@
132132
'BUILD_SET_FROM_TUPLES': 122,
133133
'BUILD_TUPLE_FROM_ITER': 123,
134134
'BUILD_TUPLE_FROM_TUPLES': 124,
135-
'CALL_METHOD_POSITIONAL': 125,
136-
'CALL_METHOD_KEYWORD': 126,
137-
'CALL_METHOD_EX': 127,
138135
'CONTINUE': 128,
139136
'JUMP_IF_FALSE_OR_POP': 129,
140137
'JUMP_IF_TRUE_OR_POP': 130,
@@ -146,7 +143,7 @@
146143
'RESUME': 149,
147144
'JUMP': 252,
148145
'LOAD_CLOSURE': 253,
149-
'LOAD_METHOD': 254,
146+
'LOAD_ATTR_METHOD': 254,
150147
'POP_BLOCK': 255,
151148
}
152149

‎Lib/test/test_xml_etree.py‎

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2301,7 +2301,6 @@ def test_bug_xmltoolkit62(self):
23012301
self.assertEqual(t.find('.//paragraph').text,
23022302
'A new cultivar of Begonia plant named \u2018BCT9801BEG\u2019.')
23032303

2304-
@unittest.expectedFailure # TODO: RUSTPYTHON
23052304
@unittest.skipIf(sys.gettrace(), "Skips under coverage.")
23062305
def test_bug_xmltoolkit63(self):
23072306
# Check reference leak.

‎crates/codegen/src/compile.rs‎

Lines changed: 150 additions & 92 deletions
Large diffs are not rendered by default.

‎crates/codegen/src/snapshots/rustpython_codegen__compile__tests__nested_double_async_with.snap‎

Lines changed: 123 additions & 117 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)