Optimize: templated literal cast (#418)

liss-h · web-flow · commit cf799b178018 · 2025-11-26T17:08:15.000+01:00
diff --git a/src/rdf4cpp/Literal.cpp b/src/rdf4cpp/Literal.cpp
@@ -890,7 +890,7 @@ std::any Literal::value() const noexcept {
             });
 }
 
-Literal Literal::cast(IRI const &target, storage::DynNodeStoragePtr node_storage) const {
+Literal Literal::cast_impl(datatypes::registry::DatatypeIDView target_dtid, storage::DynNodeStoragePtr node_storage) const {
     using namespace datatypes::registry;
     using namespace datatypes::xsd;
 
@@ -901,7 +901,6 @@ Literal Literal::cast(IRI const &target, storage::DynNodeStoragePtr node_storage
     node_storage = select_node_storage(node_storage);
 
     auto const this_dtid = this->datatype_id();
-    DatatypeIDView const target_dtid{target};
 
     if (this_dtid == target_dtid) {
         return this->to_node_storage(node_storage);
@@ -911,7 +910,7 @@ Literal Literal::cast(IRI const &target, storage::DynNodeStoragePtr node_storage
         // string -> any
         try {
             auto const lex = this->lexical_form();
-            return Literal::make_typed(lex, target, node_storage);
+            return Literal::make_typed(lex, IRI{target_dtid, node_storage}, node_storage);
         } catch (...) {
             return Literal{};
         }
@@ -984,6 +983,10 @@ Literal Literal::cast(IRI const &target, storage::DynNodeStoragePtr node_storage
     return Literal{};
 }
 
+Literal Literal::cast(IRI const &target, storage::DynNodeStoragePtr node_storage) const {
+    return this->cast_impl(static_cast<datatypes::registry::DatatypeIDView>(target), node_storage);
+}
+
 template<typename OpSelect>
     requires std::is_nothrow_invocable_r_v<datatypes::registry::DatatypeRegistry::binop_fptr_t, OpSelect, datatypes::registry::DatatypeRegistry::NumericOpsImpl const &>
 Literal Literal::numeric_binop_impl(OpSelect op_select, Literal const &other, storage::DynNodeStoragePtr node_storage) const {
diff --git a/src/rdf4cpp/Literal.hpp b/src/rdf4cpp/Literal.hpp
@@ -296,6 +296,8 @@ struct Literal : Node {
     template<bool simplified, typename C>
     auto serialize_lexical_form_impl(C &&consume) const noexcept;
 
+    [[nodiscard]] Literal cast_impl(datatypes::registry::DatatypeIDView target_dtid, storage::DynNodeStoragePtr node_storage) const;
+
     explicit Literal(storage::identifier::NodeBackendHandle handle) noexcept;
 
 public:
@@ -715,8 +717,7 @@ struct Literal : Node {
      */
     template<datatypes::LiteralDatatype T>
     [[nodiscard]] Literal cast(storage::DynNodeStoragePtr node_storage = keep_node_storage) const {
-        auto const ns = select_node_storage(node_storage);
-        return this->cast(IRI{T::datatype_id, ns}, ns);
+        return this->cast_impl(T::datatype_id, node_storage);
     }
 
     /**
