PR #43897: [ROCm] Don't use async deallocaton in MIOpen autotuner backend#120640
Merged
Conversation
d79bac4 to
ee7a25e
Compare
…kend Imported from GitHub PR openxla/xla#43897 📝 Summary of Changes Introduce file local OwningScratchAllocator implementation that does deallocation on destruction. 🎯 Justification OwningScratchAllocator implementation moved to async deallocaton model which doesn't work for miopen backend. 🚀 Kind of Contribution 🐛 Bug Fix Copybara import of the project: -- 945b5c2767fc40f51f9c045ba8766da3d728785c by Dragan Mladjenovic <Dragan.Mladjenovic@amd.com>: [ROCm] Don't use async deallocaton in MIOpen autotuner backend Merging this change closes #43897 PiperOrigin-RevId: 928753564
ee7a25e to
bb81f08
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #43897: [ROCm] Don't use async deallocaton in MIOpen autotuner backend
Imported from GitHub PR openxla/xla#43897
📝 Summary of Changes
Introduce file local OwningScratchAllocator implementation that does deallocation on destruction.
🎯 Justification
OwningScratchAllocator implementation moved to async deallocaton model which doesn't work for miopen backend.
🚀 Kind of Contribution
🐛 Bug Fix
Copybara import of the project:
--
945b5c2767fc40f51f9c045ba8766da3d728785c by Dragan Mladjenovic Dragan.Mladjenovic@amd.com:
[ROCm] Don't use async deallocaton in MIOpen autotuner backend
Merging this change closes #43897
FUTURE_COPYBARA_INTEGRATE_REVIEW=openxla/xla#43897 from ROCm:draganm/miopen_scratch_allocator 945b5c2767fc40f51f9c045ba8766da3d728785c