[XLA:GPU] Remove dynamic dimension handling from matmul_indexing_utils.#120624
Draft
copybara-service[bot] wants to merge 1 commit into
Draft
[XLA:GPU] Remove dynamic dimension handling from matmul_indexing_utils.#120624copybara-service[bot] wants to merge 1 commit into
copybara-service[bot] wants to merge 1 commit into
Conversation
3c43687 to
a608aba
Compare
a608aba to
487e214
Compare
This change removes the logic for propagating and handling dynamic dimensions within the matmul indexing utilities, specifically in `GetOutputShape` and `CollapseDimensions`. Didn't work correctly anyway. PiperOrigin-RevId: 928551333
487e214 to
5310074
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[XLA:GPU] Remove dynamic dimension handling from matmul_indexing_utils.
This change removes the logic for propagating and handling dynamic dimensions within the matmul indexing utilities, specifically in
GetOutputShapeandCollapseDimensions. Didn't work correctly anyway.