Fix redirect detection for HTTPS -> HTTPS redirect loops

semenko · semenko · commit ee65f939ae83 · 2014-05-30T14:41:28.000-04:00
Fixes http://cdt.org & closes issue EFForg#289 Signed-off-by: Nick Semenkovich <semenko@alum.mit.edu>
diff --git a/chromium/background.js b/chromium/background.js
@@ -363,8 +363,9 @@ function onCookieChanged(changeInfo) {
 }
 
 function onBeforeRedirect(details) {
-    // Catch HTTPs -> HTTP redirect loops, ignoring about:blank, HTTPS 302s, etc.
-    if (details.redirectUrl.substring(0, 7) === "http://") {
+    // Catch redirect loops (ignoring about:blank, etc. caused by other extensions)
+    var prefix = details.redirectUrl.substring(0, 5);
+    if (prefix === "http:" || prefix === "https") {
         if (details.requestId in redirectCounter) {
             redirectCounter[details.requestId] += 1;
             log(DBUG, "Got redirect id "+details.requestId+
