Fix handling of semicolon when grouping assignments (fixes andialbrecht#359).

andialbrecht · andialbrecht · commit 097478e47fbc · 2017-09-24T08:54:01.000+02:00
When grouping assignments that contain a semicolon itself, the engine was too greedy. Assignments with semicolon were introduced in 691c040.
diff --git a/CHANGELOG b/CHANGELOG
@@ -12,6 +12,7 @@ Bug Fixes
 * Fix parsing of MySQL table names starting with digits (issue337).
 * Fix detection of identifiers using comparisons (issue327).
 * Fix parsing of UNION ALL after WHERE (issue349).
+* Fix handling of semicolon in assignments (issue359, issue358).
 
 
 
diff --git a/sqlparse/engine/grouping.py b/sqlparse/engine/grouping.py
@@ -134,7 +134,7 @@ def match(token):
         return token.match(T.Assignment, ':=')
 
     def valid(token):
-        return token is not None
+        return token is not None and token.ttype not in (T.Keyword)
 
     def post(tlist, pidx, tidx, nidx):
         m_semicolon = T.Punctuation, ';'
diff --git a/tests/test_regressions.py b/tests/test_regressions.py
@@ -356,3 +356,13 @@ def test_issue322_concurrently_is_keyword():
     assert p.tokens[4].value == 'CONCURRENTLY'
     assert isinstance(p.tokens[6], sql.Identifier)
     assert p.tokens[6].value == 'myindex'
+
+
+@pytest.mark.parametrize('s', [
+    'SELECT @min_price:=MIN(price), @max_price:=MAX(price) FROM shop;',
+    'SELECT @min_price:=MIN(price), @max_price:=MAX(price) FROM shop',
+
+])
+def test_issue359_index_error_assignments(s):
+    sqlparse.parse(s)
+    sqlparse.format(s, strip_comments=True)
