doc,test: fix inspect's sorted compare function

targos · targos · commit 2b3af242d77d · 2018-09-23T19:53:17.000+02:00
In V8 7.0, the array sorting algorithm was changed to Timsort, which is stable. A compare function returning only `true` or `false` (converted to 0 and 1) cannot work properly. PR-URL: nodejs#22992 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Kyle Farnung <kfarnung@microsoft.com>
diff --git a/doc/api/util.md b/doc/api/util.md
@@ -554,7 +554,7 @@ const o1 = {
 };
 console.log(inspect(o1, { sorted: true }));
 // { a: '`a` comes before `b`', b: [ 2, 3, 1 ], c: Set { 1, 2, 3 } }
-console.log(inspect(o1, { sorted: (a, b) => a < b }));
+console.log(inspect(o1, { sorted: (a, b) => b.localeCompare(a) }));
 // { c: Set { 3, 2, 1 }, b: [ 2, 3, 1 ], a: '`a` comes before `b`' }
 
 const o2 = {
diff --git a/test/parallel/test-util-inspect.js b/test/parallel/test-util-inspect.js
@@ -1730,7 +1730,7 @@ assert.strictEqual(
 assert.strictEqual(
   inspect(
     { a200: 4, a100: 1, a102: 3, a101: 2 },
-    { sorted(a, b) { return a < b; } }
+    { sorted(a, b) { return b.localeCompare(a); } }
   ),
   '{ a200: 4, a102: 3, a101: 2, a100: 1 }'
 );
