From 2f7e361a39e98d52c3ccbfbdaf909c59009eb8f1 Mon Sep 17 00:00:00 2001 From: Chris Shin Date: Wed, 17 Jul 2019 09:13:13 -0700 Subject: [PATCH 1/4] Fix update_workbook endpoint to address #454 (#461) (cherry picked from commit bdddf97652adb73c8b8f6847b53068cac00abf9d) --- tableauserverclient/server/request_factory.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/tableauserverclient/server/request_factory.py b/tableauserverclient/server/request_factory.py index 0e528d002..0a8f5e1ba 100644 --- a/tableauserverclient/server/request_factory.py +++ b/tableauserverclient/server/request_factory.py @@ -374,7 +374,7 @@ def update_req(self, workbook_item): workbook_element = ET.SubElement(xml_request, 'workbook') if workbook_item.name: workbook_element.attrib['name'] = workbook_item.name - if workbook_item.show_tabs: + if workbook_item.show_tabs is not None: workbook_element.attrib['showTabs'] = str(workbook_item.show_tabs).lower() if workbook_item.project_id: project_element = ET.SubElement(workbook_element, 'project') @@ -382,7 +382,8 @@ def update_req(self, workbook_item): if workbook_item.owner_id: owner_element = ET.SubElement(workbook_element, 'owner') owner_element.attrib['id'] = workbook_item.owner_id - if workbook_item.materialized_views_config is not None: + if workbook_item.materialized_views_config['materialized_views_enabled']\ + and workbook_item.materialized_views_config['run_materialization_now']: materialized_views_config = workbook_item.materialized_views_config materialized_views_element = ET.SubElement(workbook_element, 'materializedViewsEnablementConfig') materialized_views_element.attrib['materializedViewsEnabled'] = str(materialized_views_config From 56801d8f72ec2e9a0c670f2d21528e089e1fe0af Mon Sep 17 00:00:00 2001 From: shinchris Date: Wed, 17 Jul 2019 10:08:44 -0700 Subject: [PATCH 2/4] Updates changelog for release 0.8.1 --- CHANGELOG.md | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 421d577fd..357a89b93 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,3 +1,7 @@ +## 0.8.1 (17 July 2019) + +* Fixed update_workbook endpoint (#454) + ## 0.8 (8 Apr 2019) * Added Max Age to download view image request (#360) From 340d82ff8ee949b4a8c710b15c422828dec3530d Mon Sep 17 00:00:00 2001 From: shinchris Date: Wed, 17 Jul 2019 10:16:26 -0700 Subject: [PATCH 3/4] Fixes test failure --- test/test_sort.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/test_sort.py b/test/test_sort.py index 88c0da728..17a69e900 100644 --- a/test/test_sort.py +++ b/test/test_sort.py @@ -58,7 +58,7 @@ def test_filter_in(self): auth_token='j80k54ll2lfMZ0tv97mlPvvSCRyD0DOM', content_type='text/xml') - self.assertEqual(resp.request.query, 'pagenumber=13&pagesize=13&filter=tags:in:[stocks,market]') + self.assertEqual(resp.request.query, 'pagenumber=13&pagesize=13&filter=tags:in:%5bstocks,market%5d') def test_sort_asc(self): with requests_mock.mock() as m: From b9ea51e1174936b0617a6e376cbd67dc99a8e38d Mon Sep 17 00:00:00 2001 From: shinchris Date: Wed, 17 Jul 2019 10:20:43 -0700 Subject: [PATCH 4/4] Removes 3.3 and 3.4 from travis --- .travis.yml | 2 -- 1 file changed, 2 deletions(-) diff --git a/.travis.yml b/.travis.yml index 01ad30886..f57c19434 100644 --- a/.travis.yml +++ b/.travis.yml @@ -1,8 +1,6 @@ language: python python: - "2.7" - - "3.3" - - "3.4" - "3.5" - "3.6" - "pypy"