From 5e39b89a3cd1e01c31373bf38cbb0fc0825f705b Mon Sep 17 00:00:00 2001
From: Chris Shin <cshin@tableau.com>
Date: Tue, 10 Apr 2018 16:27:29 -0700
Subject: [PATCH 1/2] adding ability to rename workbook using
 workbooks.update()

---
 tableauserverclient/server/request_factory.py | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/tableauserverclient/server/request_factory.py b/tableauserverclient/server/request_factory.py
index b09ecc3ce..241f47985 100644
--- a/tableauserverclient/server/request_factory.py
+++ b/tableauserverclient/server/request_factory.py
@@ -334,6 +334,8 @@ def _generate_xml(self, workbook_item, connection_credentials=None):
     def update_req(self, workbook_item):
         xml_request = ET.Element('tsRequest')
         workbook_element = ET.SubElement(xml_request, 'workbook')
+        if workbook_item.name:
+            workbook_element.attrib['name'] = workbook_item.name
         if workbook_item.show_tabs:
             workbook_element.attrib['showTabs'] = str(workbook_item.show_tabs).lower()
         if workbook_item.project_id:

From e60f296185ae059f453422729c0bdd8efe397a13 Mon Sep 17 00:00:00 2001
From: Chris Shin <cshin@tableau.com>
Date: Tue, 10 Apr 2018 16:30:15 -0700
Subject: [PATCH 2/2] updating test

---
 test/assets/workbook_update.xml | 2 +-
 test/test_workbook.py           | 2 ++
 2 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/test/assets/workbook_update.xml b/test/assets/workbook_update.xml
index 9c9674700..2470347a8 100644
--- a/test/assets/workbook_update.xml
+++ b/test/assets/workbook_update.xml
@@ -1,6 +1,6 @@
 <?xml version='1.0' encoding='UTF-8'?>
 <tsResponse xmlns="http://tableau.com/api" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://tableau.com/api http://tableau.com/api/ts-api-2.3.xsd">
-    <workbook id="1f951daf-4061-451a-9df1-69a8062664f2" name="RESTAPISample" contentUrl="RESTAPISample" showTabs="true" size="1" createdAt="2016-08-18T18:25:36Z" updatedAt="2016-08-18T18:29:36Z">
+    <workbook id="1f951daf-4061-451a-9df1-69a8062664f2" name="renamedWorkbook" contentUrl="RESTAPISample" showTabs="true" size="1" createdAt="2016-08-18T18:25:36Z" updatedAt="2016-08-18T18:29:36Z">
         <project id="1d0304cd-3796-429f-b815-7258370b9b74" name="Tableau" />
         <owner id="dd2239f6-ddf1-4107-981a-4cf94e415794" />
         <tags />
diff --git a/test/test_workbook.py b/test/test_workbook.py
index 8c36f0229..de8f8fbaf 100644
--- a/test/test_workbook.py
+++ b/test/test_workbook.py
@@ -114,12 +114,14 @@ def test_update(self):
             single_workbook = TSC.WorkbookItem('1d0304cd-3796-429f-b815-7258370b9b74', show_tabs=True)
             single_workbook._id = '1f951daf-4061-451a-9df1-69a8062664f2'
             single_workbook.owner_id = 'dd2239f6-ddf1-4107-981a-4cf94e415794'
+            single_workbook.name = 'renamedWorkbook'
             single_workbook = self.server.workbooks.update(single_workbook)
 
         self.assertEqual('1f951daf-4061-451a-9df1-69a8062664f2', single_workbook.id)
         self.assertEqual(True, single_workbook.show_tabs)
         self.assertEqual('1d0304cd-3796-429f-b815-7258370b9b74', single_workbook.project_id)
         self.assertEqual('dd2239f6-ddf1-4107-981a-4cf94e415794', single_workbook.owner_id)
+        self.assertEqual('renamedWorkbook', single_workbook.name)
 
     def test_update_missing_id(self):
         single_workbook = TSC.WorkbookItem('test')