From 23f44cbf3cda421ffc79463947e0015e6623e1e4 Mon Sep 17 00:00:00 2001 From: Russell Hay Date: Fri, 26 Jan 2018 08:22:37 -0800 Subject: [PATCH 1/3] fixes #257 --- tableauserverclient/server/request_factory.py | 2 +- test/test_regression_tests.py | 8 ++++++++ 2 files changed, 9 insertions(+), 1 deletion(-) create mode 100644 test/test_regression_tests.py diff --git a/tableauserverclient/server/request_factory.py b/tableauserverclient/server/request_factory.py index 12b0ce650..c4f10d731 100644 --- a/tableauserverclient/server/request_factory.py +++ b/tableauserverclient/server/request_factory.py @@ -401,7 +401,7 @@ def create_req(self, subscription_item): class EmptyRequest(object): @_tsrequest_wrapped - def empty_req(xml_request): + def empty_req(self, xml_request): pass diff --git a/test/test_regression_tests.py b/test/test_regression_tests.py new file mode 100644 index 000000000..6b0c2197f --- /dev/null +++ b/test/test_regression_tests.py @@ -0,0 +1,8 @@ +import unittest +import tableauserverclient.server.request_factory as factory + + +class BugFix257(unittest.TestCase): + def test_empty_request_works(self): + result = factory.EmptyRequest().empty_req() + self.assertEquals('', result) \ No newline at end of file From 794f490e65b6c8d9f8474c974117705f97f7480f Mon Sep 17 00:00:00 2001 From: Russell Hay Date: Fri, 26 Jan 2018 08:25:08 -0800 Subject: [PATCH 2/3] pyStyle fixes --- CHANGELOG.md | 4 ++++ test/test_regression_tests.py | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index a9b13a8c3..d8950a4cb 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,3 +1,7 @@ +## 0.6.1 (26 Jan 2018) + +* Fixed #257 where refreshing extracts does not work due to a missing "self" + ## 0.6 (17 Jan 2018) * Added support for add a datasource/workbook refresh to a schedule (#244) diff --git a/test/test_regression_tests.py b/test/test_regression_tests.py index 6b0c2197f..93e9b15b9 100644 --- a/test/test_regression_tests.py +++ b/test/test_regression_tests.py @@ -5,4 +5,4 @@ class BugFix257(unittest.TestCase): def test_empty_request_works(self): result = factory.EmptyRequest().empty_req() - self.assertEquals('', result) \ No newline at end of file + self.assertEquals('', result) From 11ada5559c4e3f0d13b5492a6674e158107721b5 Mon Sep 17 00:00:00 2001 From: Russell Hay Date: Fri, 26 Jan 2018 08:34:54 -0800 Subject: [PATCH 3/3] py3 vs py2 fixes --- test/test_regression_tests.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/test_regression_tests.py b/test/test_regression_tests.py index 93e9b15b9..95bdceacb 100644 --- a/test/test_regression_tests.py +++ b/test/test_regression_tests.py @@ -5,4 +5,4 @@ class BugFix257(unittest.TestCase): def test_empty_request_works(self): result = factory.EmptyRequest().empty_req() - self.assertEquals('', result) + self.assertEqual(b'', result)