Skip to content

Commit e83a74c

Browse files
committed
CONTRIBUTION.md: add tox, and details about pre-commit, fix issues
1 parent ddb70d0 commit e83a74c

1 file changed

Lines changed: 9 additions & 4 deletions

File tree

CONTRIBUTION.md

Lines changed: 9 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -20,8 +20,9 @@ https://pytest-httpserver.readthedocs.io/en/latest/background.html
2020

2121
There are a few rules you are kindly asked to accept:
2222

23-
* Coding style is checked by `pre-commit`. You can run `make precommit` before proceeding
24-
with the PR.
23+
* Coding style is checked by `pre-commit`. You can run `make precommit` before
24+
proceeding with the PR. To install the pre-commit hooks to your git (so it
25+
will be run for each commit), run `pre-commit install`.
2526

2627
* Tests should be written for the new code. If there's a complex logic
2728
implemented, it should be tested on different valid and invalid inputs and
@@ -41,11 +42,15 @@ There are a few rules you are kindly asked to accept:
4142
* You can let your IDE of your choice to use the `.venv/bin/python` interpreter,
4243
so it will know all the dependencies.
4344

44-
* running tests on the localhost can be done by issuing `make quick-test`. It is
45-
"quick" because it tests the software with only one interpreter. Note that the
45+
* running tests on the localhost can be done by issuing `make test`. Note that the
4646
library can be used by many supported interpreters and unless it is absolutely
4747
required, we don't want to drop support.
4848

49+
* running tests on multiple versions of interpreter locally can be done by
50+
`tox`. Keep in mind that the CI job uses github actions with caching for
51+
effective use, and `tox` is provided for the developers only.
52+
53+
4954
## More technical details
5055

5156
* Release notes must be written for significant changes. This is done by

0 commit comments

Comments
 (0)