CI: add windows to test platforms

csernazs · csernazs · commit b5ef9799cb70 · 2024-08-29T13:51:25.000+02:00
We run test on windows for a single python release.  This is to check
platform compatibility.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -35,11 +35,18 @@ jobs:
           make mypy
 
   test:
-    name: Test with python ${{ matrix.python-version }}
-    runs-on: ubuntu-latest
+    name: Test with python ${{ matrix.python-version }} / ${{ matrix.os-version }}
     strategy:
       matrix:
         python-version: ["3.8", "3.9", "3.10", "3.11", "3.12", "3.13-dev"]
+        os-version: ["ubuntu-latest", "windows-latest"]
+        exclude:
+          - os-version: windows-latest
+        include:
+          - os-version: windows-latest
+            python-version: 3.12
+
+    runs-on: ${{ matrix.os-version }}
 
     steps:
 
@@ -54,11 +61,24 @@ jobs:
           poetry-version: ${{ env.POETRY_VERSION }}
 
       - name: Test
+        if: runner.os == 'Linux'
         run: |
           make cov
 
+      - name: Test
+        if: runner.os == 'Windows'
+        shell: bash
+        env:
+          PYTEST_HTTPSERVER_HOST: '127.0.0.1'
+        run: |
+          set -e
+          poetry run pytest tests -s -vv --release
+          poetry run pytest tests -s -vv --ssl
+
+
       - name: Codecov upload
         uses: codecov/codecov-action@v4
+        if: runner.os == 'Linux'
         with:
           token: ${{ secrets.CODECOV_TOKEN }}
 
diff --git a/tests/test_blocking_httpserver.py b/tests/test_blocking_httpserver.py
@@ -122,4 +122,4 @@ def test_raises_assertion_error_when_request_was_not_responded(httpserver: Block
 
 
 def test_repr(httpserver: BlockingHTTPServer):
-    assert repr(httpserver) == f"<BlockingHTTPServer host=localhost port={httpserver.port}>"
+    assert repr(httpserver) == f"<BlockingHTTPServer host={httpserver.host} port={httpserver.port}>"
diff --git a/tests/test_log_querying.py b/tests/test_log_querying.py
@@ -47,7 +47,7 @@ def test_verify_assert_msg(httpserver: HTTPServer):
         "Path: /foo",
         "Method: GET",
         "Body: b''",
-        f"Headers: Host: localhost:{httpserver.port}",
+        f"Headers: Host: {httpserver.host}:{httpserver.port}",
         "User-Agent: requests",
         "Accept-Encoding: gzip, deflate",
         "Accept: */*",
diff --git a/tests/test_mixed.py b/tests/test_mixed.py
@@ -85,4 +85,4 @@ def test_all_ordered_missing(httpserver: HTTPServer):
 
 
 def test_repr(httpserver: HTTPServer):
-    assert repr(httpserver) == f"<HTTPServer host=localhost port={httpserver.port}>"
+    assert repr(httpserver) == f"<HTTPServer host={httpserver.host} port={httpserver.port}>"
diff --git a/tests/test_ssl.py b/tests/test_ssl.py
@@ -5,6 +5,8 @@
 import pytest
 import requests
 
+from pytest_httpserver import HTTPServer
+
 pytestmark = pytest.mark.ssl
 
 test_dir = os.path.dirname(os.path.realpath(__file__))
@@ -24,18 +26,23 @@ def httpserver_ssl_context():
     return ssl.SSLContext(protocol)
 
 
-def test_ssl(httpserver):
+def test_ssl(httpserver: HTTPServer):
     server_crt = pjoin(assets_dir, "server.crt")
     server_key = pjoin(assets_dir, "server.key")
     root_ca = pjoin(assets_dir, "rootCA.crt")
-    context = httpserver.ssl_context
 
     assert (
-        context is not None
+        httpserver.ssl_context is not None
     ), "SSLContext not set. The session was probably started with a test that did not define an SSLContext."
 
     httpserver.ssl_context.load_cert_chain(server_crt, server_key)
     httpserver.expect_request("/foobar").respond_with_json({"foo": "bar"})
 
     assert httpserver.is_running()
-    assert requests.get(httpserver.url_for("/foobar"), verify=root_ca).json() == {"foo": "bar"}
+
+    assert httpserver.url_for("/").startswith("https://")
+
+    # ensure we are using "localhost" and not "127.0.0.1" to pass cert verification
+    url = f"https://localhost:{httpserver.port}/foobar"
+
+    assert requests.get(url, verify=root_ca).json() == {"foo": "bar"}

Original file line number	Diff line number	Diff line change
`@@ -122,4 +122,4 @@ def test_raises_assertion_error_when_request_was_not_responded(httpserver: Block`
`122`	`122`
`123`	`123`
`124`	`124`	`def test_repr(httpserver: BlockingHTTPServer):`
`125`		`- assert repr(httpserver) == f"<BlockingHTTPServer host=localhost port={httpserver.port}>"`
	`125`	`+ assert repr(httpserver) == f"<BlockingHTTPServer host={httpserver.host} port={httpserver.port}>"`
Original file line number	Diff line number	Diff line change
`@@ -85,4 +85,4 @@ def test_all_ordered_missing(httpserver: HTTPServer):`
`85`	`85`
`86`	`86`
`87`	`87`	`def test_repr(httpserver: HTTPServer):`
`88`		`- assert repr(httpserver) == f"<HTTPServer host=localhost port={httpserver.port}>"`
	`88`	`+ assert repr(httpserver) == f"<HTTPServer host={httpserver.host} port={httpserver.port}>"`