httpserver.py: fix werkzeug deprecated parse_authorization_header call

csernazs · csernazs · commit 089511d90dcb · 2023-05-16T20:44:55.000+02:00
Replace parse_authorization_header with Authorization.from_header as
suggested.

Fall back to parse_authorization_header if Authorization.from_header is not
defined for backward compatibility.
diff --git a/pytest_httpserver/httpserver.py b/pytest_httpserver/httpserver.py
@@ -23,8 +23,9 @@
 from typing import Tuple
 from typing import Union
 
+import werkzeug.http
+from werkzeug.datastructures import Authorization
 from werkzeug.datastructures import MultiDict
-from werkzeug.http import parse_authorization_header
 from werkzeug.serving import make_server
 from werkzeug.wrappers import Request
 from werkzeug.wrappers import Response
@@ -133,7 +134,10 @@ def __init__(self, matchers: Optional[Mapping[str, Callable[[Optional[str], str]
 
     @staticmethod
     def authorization_header_value_matcher(actual: Optional[str], expected: str) -> bool:
-        return parse_authorization_header(actual) == parse_authorization_header(expected)
+        callable = getattr(Authorization, "from_header", None)
+        if callable is None:  # Werkzeug < 2.3.0
+            callable = werkzeug.http.parse_authorization_header
+        return callable(actual) == callable(expected)
 
     @staticmethod
     def default_header_value_matcher(actual: Optional[str], expected: str) -> bool:
diff --git a/releasenotes/notes/werkzeug-parse_authorization_header-deprecation-fix-8264966b70fddc6d.yaml b/releasenotes/notes/werkzeug-parse_authorization_header-deprecation-fix-8264966b70fddc6d.yaml
@@ -0,0 +1,7 @@
+---
+fixes:
+  - |
+    Fix Werkzeug deprecation warning about ``parse_authorization_header`` call.
+    Replace ``parse_authorization_header`` with ``Authorization.from_header`` as
+    suggested. This fix should not introduce any functional change for the
+    users.
