src: fix handle leak in Parser::Execute()

bnoordhuis · trevnorris · commit de9a444ab4c1 · 2014-09-05T09:33:49.000-07:00
Fix a resource leak where an intermediate Local&lt;Context&gt; handle in
Environment::GetCurrent() got leaked into whatever HandleScope was
further up the stack.

Reviewed-by: Trevor Norris &lt;trev.norris@gmail.com&gt;
diff --git a/src/node_http_parser.cc b/src/node_http_parser.cc
@@ -373,8 +373,8 @@ class Parser : public BaseObject {
 
   // var bytesParsed = parser->execute(buffer);
   static void Execute(const FunctionCallbackInfo<Value>& args) {
+    HandleScope handle_scope(args.GetIsolate());
     Environment* env = Environment::GetCurrent(args.GetIsolate());
-    HandleScope scope(env->isolate());
 
     Parser* parser = Unwrap<Parser>(args.Holder());
     assert(parser->current_buffer_.IsEmpty());
