chore!: Deprecate positional arguments for feature services (feast-dev#3051)

felixwang9817 · web-flow · commit e169729b89e4 · 2022-08-10T13:13:59.000-07:00
* Clean up feature service

Signed-off-by: Felix Wang &lt;wangfelix98@gmail.com&gt;

* Delete unnecessary feature service test

Signed-off-by: Felix Wang &lt;wangfelix98@gmail.com&gt;

* Fix docstring

Signed-off-by: Felix Wang &lt;wangfelix98@gmail.com&gt;

Signed-off-by: Felix Wang &lt;wangfelix98@gmail.com&gt;
diff --git a/sdk/python/feast/feature_service.py b/sdk/python/feast/feature_service.py
@@ -1,4 +1,3 @@
-import warnings
 from datetime import datetime
 from typing import Dict, List, Optional, Union
 
@@ -53,9 +52,9 @@ class FeatureService:
     @log_exceptions
     def __init__(
         self,
-        *args,
-        name: Optional[str] = None,
-        features: Optional[List[Union[FeatureView, OnDemandFeatureView]]] = None,
+        *,
+        name: str,
+        features: List[Union[FeatureView, OnDemandFeatureView]],
         tags: Dict[str, str] = None,
         description: str = "",
         owner: str = "",
@@ -64,39 +63,17 @@ def __init__(
         """
         Creates a FeatureService object.
 
-        Raises:
-            ValueError: If one of the specified features is not a valid type.
+        Args:
+            name: The unique name of the feature service.
+            feature_view_projections: A list containing feature views and feature view
+                projections, representing the features in the feature service.
+            description (optional): A human-readable description.
+            tags (optional): A dictionary of key-value pairs to store arbitrary metadata.
+            owner (optional): The owner of the feature view, typically the email of the
+                primary maintainer.
         """
-        positional_attributes = ["name", "features"]
-        _name = name
-        _features = features
-        if args:
-            warnings.warn(
-                (
-                    "Feature service parameters should be specified as a keyword argument instead of a positional arg."
-                    "Feast 0.24+ will not support positional arguments to construct feature service"
-                ),
-                DeprecationWarning,
-            )
-            if len(args) > len(positional_attributes):
-                raise ValueError(
-                    f"Only {', '.join(positional_attributes)} are allowed as positional args when defining "
-                    f"feature service, for backwards compatibility."
-                )
-            if len(args) >= 1:
-                _name = args[0]
-            if len(args) >= 2:
-                _features = args[1]
-
-        if not _name:
-            raise ValueError("Feature service name needs to be specified")
-
-        if not _features:
-            # Technically, legal to create feature service with no feature views before.
-            _features = []
-
-        self.name = _name
-        self._features = _features
+        self.name = name
+        self._features = features
         self.feature_view_projections = []
         self.description = description
         self.tags = tags or {}
diff --git a/sdk/python/tests/unit/test_feature_service.py b/sdk/python/tests/unit/test_feature_service.py
@@ -1,5 +1,3 @@
-import pytest
-
 from feast.feature_service import FeatureService
 from feast.feature_view import FeatureView
 from feast.field import Field
@@ -59,22 +57,6 @@ def test_hash():
     assert len(s4) == 3
 
 
-def test_feature_view_kw_args_warning():
-    with pytest.warns(DeprecationWarning):
-        service = FeatureService("name", [], tags={"tag_1": "tag"}, description="desc")
-        assert service.name == "name"
-        assert service.tags == {"tag_1": "tag"}
-        assert service.description == "desc"
-
-    # More positional args than name and features
-    with pytest.raises(ValueError):
-        service = FeatureService("name", [], {"tag_1": "tag"}, "desc")
-
-    # No name defined.
-    with pytest.raises(ValueError):
-        service = FeatureService(features=[], tags={"tag_1": "tag"}, description="desc")
-
-
 @no_warnings
 def test_feature_view_kw_args_normal():
     file_source = FileSource(name="my-file-source", path="test.parquet")
