fix: Async logging should not rethrow error in onFailure callback (googleapis#923)

losalex · web-flow · commit c46cadaa621c · 2022-03-31T10:03:53.000-07:00
diff --git a/java-logging/google-cloud-logging/src/main/java/com/google/cloud/logging/LoggingImpl.java b/java-logging/google-cloud-logging/src/main/java/com/google/cloud/logging/LoggingImpl.java
@@ -882,7 +882,7 @@ public void flush() {
     try {
       ApiFutures.allAsList(writesToFlush).get(FLUSH_WAIT_TIMEOUT_SECONDS, TimeUnit.SECONDS);
     } catch (InterruptedException | ExecutionException | TimeoutException e) {
-      throw new RuntimeException(e);
+      System.err.println("ERROR: flush failure: " + e);
     }
   }
 

Original file line number	Diff line number	Diff line change
`@@ -882,7 +882,7 @@ public void flush() {`
`882`	`882`	`try {`
`883`	`883`	`ApiFutures.allAsList(writesToFlush).get(FLUSH_WAIT_TIMEOUT_SECONDS, TimeUnit.SECONDS);`
`884`	`884`	`} catch (InterruptedException \| ExecutionException \| TimeoutException e) {`
`885`		`- throw new RuntimeException(e);`
	`885`	`+ System.err.println("ERROR: flush failure: " + e);`
`886`	`886`	`}`
`887`	`887`	`}`
`888`	`888`