- code linting

baywet · baywet · commit 43eaec583748 · 2023-11-14T09:33:26.000-05:00
diff --git a/src/main/java/com/microsoft/graph/content/BatchResponseContent.java b/src/main/java/com/microsoft/graph/content/BatchResponseContent.java
@@ -49,7 +49,7 @@ public BatchResponseContent(@Nonnull Response batchResponse, @Nullable Map<Strin
      * @return The responses of the batch request.
      */
     @Nonnull
-    public HashMap<String, Response> getResponses() {
+    public Map<String, Response> getResponses() {
         HashMap<String, Response> responses = new HashMap<>();
         jsonBatchResponseObject = jsonBatchResponseObject != null ? jsonBatchResponseObject : getBatchResponseContent();
         if (jsonBatchResponseObject != null) {
@@ -68,7 +68,7 @@ public HashMap<String, Response> getResponses() {
      * @return The status codes of the responses of the batch request.
      */
     @Nonnull
-    public HashMap<String, Integer> getResponsesStatusCode() {
+    public Map<String, Integer> getResponsesStatusCode() {
         HashMap<String, Integer> statusCodes = new HashMap<>();
         jsonBatchResponseObject = jsonBatchResponseObject != null ? jsonBatchResponseObject : getBatchResponseContent();
         if (jsonBatchResponseObject != null) {
diff --git a/src/main/java/com/microsoft/graph/content/BatchResponseContentCollection.java b/src/main/java/com/microsoft/graph/content/BatchResponseContentCollection.java
@@ -100,7 +100,7 @@ public InputStream getResponseStreamById(@Nonnull String requestId) {
     public Map<String, Integer> getResponsesStatusCodes() {
         HashMap<String, Integer> statusCodes = new HashMap<>();
         for(KeyedBatchResponseContent keyedResponse : batchResponses) {
-            HashMap<String, Integer> responseStatusCodes = keyedResponse.response.getResponsesStatusCode();
+            Map<String, Integer> responseStatusCodes = keyedResponse.response.getResponsesStatusCode();
             statusCodes.putAll(responseStatusCodes);
         }
         return statusCodes;
diff --git a/src/main/java/com/microsoft/graph/requests/ResponseBodyHandler.java b/src/main/java/com/microsoft/graph/requests/ResponseBodyHandler.java
@@ -45,7 +45,7 @@ public ResponseBodyHandler(@Nonnull ParsableFactory<T> factory) {
      * @param <NativeResponseType> The type of the native response object.
      * @param <ModelType> The type of the response model object.
      */
-    @Nonnull
+    @Nullable
     @Override
     public <NativeResponseType, ModelType> ModelType handleResponse(@Nonnull NativeResponseType response, @Nullable HashMap<String, ParsableFactory<? extends Parsable>> errorMappings) {
         if(response instanceof Response && ((Response) response).body()!=null) {
diff --git a/src/test/java/com/microsoft/graph/content/BatchResponseContentTest.java b/src/test/java/com/microsoft/graph/content/BatchResponseContentTest.java
@@ -13,6 +13,7 @@
 import java.io.InputStream;
 import java.net.HttpURLConnection;
 import java.util.HashMap;
+import java.util.Map;
 
 import static com.microsoft.kiota.serialization.ParseNodeFactoryRegistry.defaultInstance;
 import static org.junit.jupiter.api.Assertions.*;
@@ -26,7 +27,7 @@ class BatchResponseContentTest {
     void BatchResponseContent_InitializeWithNoContent() {
         Response response = defaultBuilder.code(HttpURLConnection.HTTP_BAD_REQUEST).build();
         BatchResponseContent batchResponseContent = new BatchResponseContent(response);
-        HashMap<String, Response> responses = batchResponseContent.getResponses();
+        Map<String, Response> responses = batchResponseContent.getResponses();
         Response response1 = responses.get("1");
         assertNotNull(responses);
         assertNull(response1);
@@ -38,7 +39,7 @@ void BatchResponseContent_InitializeWithEmptyResponseContent() {
         ResponseBody responseBody = ResponseBody.create(jsonResponse,MediaType.get("application/json"));
         Response response = defaultBuilder.code(HttpURLConnection.HTTP_BAD_REQUEST).body(responseBody).build();
         BatchResponseContent batchResponseContent = new BatchResponseContent(response);
-        HashMap<String, Response> responses = batchResponseContent.getResponses();
+        Map<String, Response> responses = batchResponseContent.getResponses();
         Response response1 = batchResponseContent.getResponseById("1");
         assertNotNull(responses);
         assertNull(response1);
@@ -77,7 +78,7 @@ void BatchResponseContent_GetResponses() {
         Response response = defaultBuilder.code(HttpURLConnection.HTTP_OK).body(body).build();
         BatchResponseContent batchResponseContent = new BatchResponseContent(response);
 
-        HashMap<String, Response> responses = batchResponseContent.getResponses();
+        Map<String, Response> responses = batchResponseContent.getResponses();
 
         assertNotNull(responses);
         assertEquals(3, responses.size());

Original file line number	Diff line number	Diff line change
`@@ -100,7 +100,7 @@ public InputStream getResponseStreamById(@Nonnull String requestId) {`
`100`	`100`	`public Map<String, Integer> getResponsesStatusCodes() {`
`101`	`101`	`HashMap<String, Integer> statusCodes = new HashMap<>();`
`102`	`102`	`for(KeyedBatchResponseContent keyedResponse : batchResponses) {`
`103`		`- HashMap<String, Integer> responseStatusCodes = keyedResponse.response.getResponsesStatusCode();`
	`103`	`+ Map<String, Integer> responseStatusCodes = keyedResponse.response.getResponsesStatusCode();`
`104`	`104`	`statusCodes.putAll(responseStatusCodes);`
`105`	`105`	`}`
`106`	`106`	`return statusCodes;`