Skip to content

Commit fd0be8c

Browse files
jsa34baev
authored andcommitted
update cucumber-jvm (via allure-framework#392)
1 parent f50f4b9 commit fd0be8c

14 files changed

Lines changed: 108 additions & 108 deletions

File tree

allure-cucumber3-jvm/build.gradle.kts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ description = "Allure CucumberJVM 3.0 Integration"
22

33
val agent: Configuration by configurations.creating
44

5-
val cucumberVersion = "3.0.0"
5+
val cucumberVersion = "3.0.2"
66

77
dependencies {
88
agent("org.aspectj:aspectjweaver")

allure-cucumber4-jvm/build.gradle.kts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ description = "Allure CucumberJVM 4.0"
22

33
val agent: Configuration by configurations.creating
44

5-
val cucumberVersion = "4.3.1"
5+
val cucumberVersion = "4.7.2"
66

77
dependencies {
88
agent("org.aspectj:aspectjweaver")

allure-cucumber4-jvm/src/main/java/io/qameta/allure/cucumber4jvm/AllureCucumber4Jvm.java

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,6 @@
5252
import io.qameta.allure.model.TestResultContainer;
5353

5454
import java.io.ByteArrayInputStream;
55-
import java.nio.charset.Charset;
5655
import java.nio.charset.StandardCharsets;
5756
import java.util.Collections;
5857
import java.util.Deque;
@@ -71,7 +70,7 @@
7170
import static io.qameta.allure.util.ResultsUtils.md5;
7271

7372
/**
74-
* Allure plugin for Cucumber JVM 3.0.
73+
* Allure plugin for Cucumber JVM 4.0.
7574
*/
7675
@SuppressWarnings({
7776
"PMD.ExcessiveImports",
@@ -331,7 +330,7 @@ private void createDataTableAttachment(final PickleTable pickleTable) {
331330
final String attachmentSource = lifecycle
332331
.prepareAttachment("Data table", "text/tab-separated-values", "csv");
333332
lifecycle.writeAttachment(attachmentSource,
334-
new ByteArrayInputStream(dataTableCsv.toString().getBytes(Charset.forName("UTF-8"))));
333+
new ByteArrayInputStream(dataTableCsv.toString().getBytes(StandardCharsets.UTF_8)));
335334
}
336335
}
337336

@@ -343,7 +342,7 @@ private void handleHookStep(final TestStepFinished event) {
343342
if (!Status.PASSED.equals(fixtureResult.getStatus())) {
344343
final TestResult testResult = new TestResult().setStatus(translateTestCaseStatus(event.result));
345344
final StatusDetails statusDetails = getStatusDetails(event.result.getError())
346-
.orElseGet(() -> new StatusDetails());
345+
.orElseGet(StatusDetails::new);
347346

348347
final String errorMessage = event.result.getError() == null ? hookStep.getHookType()
349348
.name() + " is failed." : hookStep.getHookType()

allure-cucumber4-jvm/src/test/java/io/qameta/allure/cucumber4jvm/AllureCucumber4JvmTest.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@
1818
import cucumber.runtime.ClassFinder;
1919
import cucumber.runtime.FeatureSupplier;
2020
import cucumber.runtime.Runtime;
21-
import cucumber.runtime.RuntimeOptions;
2221
import cucumber.runtime.io.MultiLoader;
2322
import cucumber.runtime.io.ResourceLoader;
2423
import cucumber.runtime.io.ResourceLoaderClassFinder;
@@ -30,6 +29,8 @@
3029
import gherkin.events.PickleEvent;
3130
import gherkin.pickles.Compiler;
3231
import gherkin.pickles.Pickle;
32+
import io.cucumber.core.options.CommandlineOptionsParser;
33+
import io.cucumber.core.options.RuntimeOptions;
3334
import io.github.glytching.junit.extension.system.SystemProperty;
3435
import io.github.glytching.junit.extension.system.SystemPropertyExtension;
3536
import io.qameta.allure.AllureLifecycle;
@@ -725,7 +726,7 @@ private byte runFeature(final AllureResultsWriterStub writer,
725726
"--plugin", "null_summary"
726727
));
727728
opts.addAll(Arrays.asList(moreOptions));
728-
final RuntimeOptions options = new RuntimeOptions(opts);
729+
final RuntimeOptions options = new CommandlineOptionsParser().parse(opts).build();
729730
boolean mt = options.isMultiThreaded();
730731

731732
FeatureSupplier featureSupplier = () -> {

allure-cucumber4-jvm/src/test/java/io/qameta/allure/cucumber4jvm/samples/AmbigiousSteps.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,8 @@
1515
*/
1616
package io.qameta.allure.cucumber4jvm.samples;
1717

18-
import cucumber.api.java.en.Then;
19-
import cucumber.api.java.en.When;
18+
import io.cucumber.java.en.Then;
19+
import io.cucumber.java.en.When;
2020

2121
/**
2222
* @author charlie (Dmitry Baev).

allure-cucumber4-jvm/src/test/java/io/qameta/allure/cucumber4jvm/samples/AttachmentSteps.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,9 +15,9 @@
1515
*/
1616
package io.qameta.allure.cucumber4jvm.samples;
1717

18-
import cucumber.api.Scenario;
19-
import cucumber.api.java.Before;
20-
import cucumber.api.java.en.Given;
18+
import io.cucumber.core.api.Scenario;
19+
import io.cucumber.java.Before;
20+
import io.cucumber.java.en.Given;
2121

2222
public class AttachmentSteps
2323
{

allure-cucumber4-jvm/src/test/java/io/qameta/allure/cucumber4jvm/samples/BackgroundFeatureSteps.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,9 +15,9 @@
1515
*/
1616
package io.qameta.allure.cucumber4jvm.samples;
1717

18-
import cucumber.api.java.en.Given;
19-
import cucumber.api.java.en.Then;
20-
import cucumber.api.java.en.When;
18+
import io.cucumber.java.en.Given;
19+
import io.cucumber.java.en.Then;
20+
import io.cucumber.java.en.When;
2121

2222
/**
2323
* @author charlie (Dmitry Baev).

allure-cucumber4-jvm/src/test/java/io/qameta/allure/cucumber4jvm/samples/BrokenFeatureSteps.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
*/
1616
package io.qameta.allure.cucumber4jvm.samples;
1717

18-
import cucumber.api.java.en.Given;
18+
import io.cucumber.java.en.Given;
1919

2020
/**
2121
* @author charlie (Dmitry Baev).

allure-cucumber4-jvm/src/test/java/io/qameta/allure/cucumber4jvm/samples/DatatableFeatureSteps.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
*/
1616
package io.qameta.allure.cucumber4jvm.samples;
1717

18-
import cucumber.api.java.en.Given;
18+
import io.cucumber.java.en.Given;
1919
import io.cucumber.datatable.DataTable;
2020

2121
/**

allure-cucumber4-jvm/src/test/java/io/qameta/allure/cucumber4jvm/samples/HookSteps.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,8 @@
1515
*/
1616
package io.qameta.allure.cucumber4jvm.samples;
1717

18-
import cucumber.api.java.After;
19-
import cucumber.api.java.Before;
18+
import io.cucumber.java.After;
19+
import io.cucumber.java.Before;
2020
import org.testng.Assert;
2121

2222
/**

0 commit comments

Comments
 (0)