Repository navigation
✨(frontend) add top parent on sub docs search - #1952
Merged
Merged
Conversation
Contributor
|
Size Change: -254 B (-0.01%) Total Size: 4.33 MB 📦 View Changed
|
AntoLC
force-pushed
the
refacto/sub-docs-search
branch
2 times, most recently
from
March 19, 2026 13:24
0bf9667 to
c89909b
Compare
AntoLC
force-pushed
the
refacto/sub-docs-search
branch
from
June 2, 2026 16:33
c89909b to
d213b2e
Compare
AntoLC
force-pushed
the
refacto/sub-docs-search
branch
2 times, most recently
from
June 5, 2026 09:10
bab36fd to
c93a524
Compare
Contributor
|
🚀 Preview will be available at https://1952-docs.ppr-docs.beta.numerique.gouv.fr/ You can use the existing account with these credentials:
You can also create a new account if you want to. Once this Pull Request is merged, the preview will be destroyed. |
AntoLC
force-pushed
the
refacto/sub-docs-search
branch
2 times, most recently
from
June 5, 2026 13:02
511add0 to
5039cb2
Compare
AntoLC
marked this pull request as ready for review
June 5, 2026 13:02
AntoLC
force-pushed
the
refacto/sub-docs-search
branch
from
June 5, 2026 15:33
5039cb2 to
c5974a8
Compare
AntoLC
force-pushed
the
refacto/sub-docs-search
branch
3 times, most recently
from
June 9, 2026 07:29
a1df949 to
e2caf4f
Compare
Ovgodd
requested changes
Jun 9, 2026
Ovgodd
left a comment
Collaborator
There was a problem hiding this comment.
It works well on my side, just a few suggestions in terms of accessibility and readability.
| }, [search]); | ||
|
|
||
| useEffect(() => { | ||
| setFilter(defaultFilters); |
Collaborator
There was a problem hiding this comment.
Suggested change
| setFilter(defaultFilters); | |
| setFilter(defaultFilters); | |
| return () => setFilter('all'); |
Should we cleanup the filter ? if the user opens the modal, toggle the filter, then closes and reposens on the same doc, defaultFilter don't change so the store will keep the old value ?
Member
Author
There was a problem hiding this comment.
I don't think it keeps the old filter, try again maybe ?
I don't clean it because depends some states of the doc, the default filter is different:
Collaborator
There was a problem hiding this comment.
OK I see ! thanks for the explanations
Comment on lines
+66
to
+68
| useEffect(() => { | ||
| setFilter('current'); | ||
| }, [setFilter]); |
Collaborator
There was a problem hiding this comment.
Suggested change
| useEffect(() => { | |
| setFilter('current'); | |
| }, [setFilter]); | |
| useEffect(() => { | |
| setFilter('current'); | |
| return () => setFilter('all') | |
| }, [setFilter]); |
Should we cleanup here the filter ? . If the user closes the interlinking and then opens the search modal, the filter will still be not reset ?
Member
Author
There was a problem hiding this comment.
There is not a static default filter, depend the state of the doc, the default change, so we force onMount the default filter that we want to use.
AntoLC
force-pushed
the
refacto/sub-docs-search
branch
from
June 9, 2026 15:55
e2caf4f to
ca46c93
Compare
Ovgodd
approved these changes
Jun 10, 2026
AntoLC
force-pushed
the
refacto/sub-docs-search
branch
from
June 10, 2026 13:26
ca46c93 to
e50ca93
Compare
In the search endpoint, we were returning all the parents for a document mathing the search. We want instead to return only the top parent the user has access to.
In the search modal, under the sub docs, we now display the top parent of the doc, to give more context to the user about the doc they are looking for. We refactorize the filters to get more flexibility and avoid too much props drilling.
The search ui has been updated to fit the design mockup. It includes: - the search feature - the move doc modal - the interlinking search part
Improve accessibility of search components by adding appropriate ARIA attributes and enhancing screen reader compatibility.
AntoLC
force-pushed
the
refacto/sub-docs-search
branch
from
June 10, 2026 14:51
e50ca93 to
6ce8533
Compare
Merged
lunika
added a commit
that referenced
this pull request
Jun 19, 2026
Added - ✨(backend) add limit on distinct reactions per comment #1978 - ✨(frontend) leave a document #2410 - ✨(frontend) add top parent on sub docs search #1952 - ✨(frontend) unauthenticated users can search #2407 - ✨(backend) specific user delete method to delete its relations #2437 Changed - 👷(CI) remove test-e2e-other-browser job #2404 - ♿️(frontend) use heading element for pinned documents section title #2380 - ♿️(frontend) use anchor links for table of contents entries #2390 - ♿️(frontend) improve presenter mode screen reader and keyboard support #2383 - ♿️(frontend) link export modal name to its heading #2422 Fixed - 🐛(frontend) overlap of block menu dropdown #2406 - ⚡️(backend) fix N+1 queries when serializing thread comments #2415
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
In the search modal, under the sub docs, we now display the top parent of the doc, to give more context to the user about the doc they are looking for.
We refactorize the filters to get more flexibility and avoid too much props drilling.
Demo
Enregistrement.2026-06-05.111227.mp4