Merge branch 'develop' into cleanup-examples

felixdivo · web-flow · commit e611e08a14cd · 2019-09-12T09:05:50.000+02:00
diff --git a/.travis.yml b/.travis.yml
@@ -80,13 +80,23 @@ jobs:
       before_install:
         - travis_retry pip install -r requirements-lint.txt
       script:
+        # -------------
+        # pylint checking:
         # Slowly enable all pylint warnings by adding addressed classes of
         # warnings to the .pylintrc-wip file to prevent them from being
         # re-introduced
+        # check the entire main codebase
         - pylint --rcfile=.pylintrc-wip can/**.py
-        # check examples
+        # check setup.py
+        - pylint --rcfile=.pylintrc *.py
+        # check doc/conf.py and possible other scripts in there
+        - pylint --rcfile=.pylintrc doc/**.py
+        # check the scripts folder
+        - pylint --rcfile=.pylintrc scripts/**.py
+        # check the examples
         - pylint --rcfile=.pylintrc-wip examples/**.py
-        # mypy checking
+        # -------------
+        # mypy checking:
         - mypy
           --python-version=3.7
           --ignore-missing-imports
diff --git a/can/__init__.py b/can/__init__.py
@@ -1,5 +1,3 @@
-# coding: utf-8
-
 """
 ``can`` is an object-orient Controller Area Network (CAN) interface module.
 """
diff --git a/can/broadcastmanager.py b/can/broadcastmanager.py
@@ -1,5 +1,3 @@
-# coding: utf-8
-
 """
 Exposes several methods for transmitting cyclic messages.
 
diff --git a/can/bus.py b/can/bus.py
@@ -1,5 +1,3 @@
-# coding: utf-8
-
 """
 Contains the ABC bus implementation and its documentation.
 """
diff --git a/can/ctypesutil.py b/can/ctypesutil.py
@@ -1,5 +1,3 @@
-# coding: utf-8
-
 """
 This module contains common `ctypes` utils.
 """
diff --git a/can/interface.py b/can/interface.py
@@ -1,5 +1,3 @@
-# coding: utf-8
-
 """
 This module contains the base implementation of :class:`can.BusABC` as well
 as a list of all available backends and some implemented
diff --git a/can/interfaces/__init__.py b/can/interfaces/__init__.py
@@ -1,5 +1,3 @@
-# coding: utf-8
-
 """
 Interfaces contain low level implementations that interact with CAN hardware.
 """
diff --git a/can/interfaces/canalystii.py b/can/interfaces/canalystii.py
@@ -1,5 +1,3 @@
-# coding: utf-8
-
 from ctypes import *
 import logging
 import platform
diff --git a/can/interfaces/ics_neovi/__init__.py b/can/interfaces/ics_neovi/__init__.py
@@ -1,5 +1,3 @@
-# coding: utf-8
-
 """
 """
 
diff --git a/can/interfaces/ics_neovi/neovi_bus.py b/can/interfaces/ics_neovi/neovi_bus.py
@@ -1,5 +1,3 @@
-# coding: utf-8
-
 """
 ICS NeoVi interface module.
 
diff --git a/can/interfaces/iscan.py b/can/interfaces/iscan.py
@@ -1,5 +1,3 @@
-# coding: utf-8
-
 """
 Interface for isCAN from Thorsis Technologies GmbH, former ifak system GmbH.
 """
diff --git a/can/interfaces/ixxat/__init__.py b/can/interfaces/ixxat/__init__.py
@@ -1,5 +1,3 @@
-# coding: utf-8
-
 """
 Ctypes wrapper module for IXXAT Virtual CAN Interface V3 on win32 systems
 
diff --git a/can/interfaces/ixxat/canlib.py b/can/interfaces/ixxat/canlib.py
@@ -1,5 +1,3 @@
-# coding: utf-8
-
 """
 Ctypes wrapper module for IXXAT Virtual CAN Interface V3 on win32 systems
 
diff --git a/can/interfaces/ixxat/constants.py b/can/interfaces/ixxat/constants.py
@@ -1,5 +1,3 @@
-# coding: utf-8
-
 """
 Ctypes wrapper module for IXXAT Virtual CAN Interface V3 on win32 systems
 
diff --git a/can/interfaces/ixxat/exceptions.py b/can/interfaces/ixxat/exceptions.py
@@ -1,5 +1,3 @@
-# coding: utf-8
-
 """
 Ctypes wrapper module for IXXAT Virtual CAN Interface V3 on win32 systems
 
diff --git a/can/interfaces/ixxat/structures.py b/can/interfaces/ixxat/structures.py
@@ -1,5 +1,3 @@
-# coding: utf-8
-
 """
 Ctypes wrapper module for IXXAT Virtual CAN Interface V3 on win32 systems
 
diff --git a/can/interfaces/kvaser/__init__.py b/can/interfaces/kvaser/__init__.py
@@ -1,5 +1,3 @@
-# coding: utf-8
-
 """
 """
 
diff --git a/can/interfaces/kvaser/canlib.py b/can/interfaces/kvaser/canlib.py
@@ -1,5 +1,3 @@
-# coding: utf-8
-
 """
 Contains Python equivalents of the function and constant
 definitions in CANLIB's canlib.h, with some supporting functionality
diff --git a/can/interfaces/kvaser/constants.py b/can/interfaces/kvaser/constants.py
@@ -1,5 +1,3 @@
-# coding: utf-8
-
 """
 Contains Python equivalents of the function and constant
 definitions in CANLIB's canstat.h, with some supporting functionality
diff --git a/can/interfaces/kvaser/structures.py b/can/interfaces/kvaser/structures.py
@@ -1,5 +1,3 @@
-# coding: utf-8
-
 """
 Contains Python equivalents of the structures in CANLIB's canlib.h,
 with some supporting functionality specific to Python.
diff --git a/can/interfaces/nican.py b/can/interfaces/nican.py
@@ -1,5 +1,3 @@
-# coding: utf-8
-
 """
 NI-CAN interface module.
 
diff --git a/can/interfaces/pcan/__init__.py b/can/interfaces/pcan/__init__.py
@@ -1,5 +1,3 @@
-# coding: utf-8
-
 """
 """
 
diff --git a/can/interfaces/pcan/basic.py b/can/interfaces/pcan/basic.py
@@ -1,5 +1,3 @@
-# coding: utf-8
-
 """
 PCAN-Basic API
 
diff --git a/can/interfaces/pcan/pcan.py b/can/interfaces/pcan/pcan.py
@@ -1,5 +1,3 @@
-# coding: utf-8
-
 """
 Enable basic CAN over a PCAN USB device.
 """
diff --git a/can/interfaces/seeedstudio/__init__.py b/can/interfaces/seeedstudio/__init__.py
@@ -1,5 +1,3 @@
-# coding: utf-8
-
 """
 """
 
diff --git a/can/interfaces/seeedstudio/seeedstudio.py b/can/interfaces/seeedstudio/seeedstudio.py
@@ -1,5 +1,3 @@
-# coding: utf-8
-
 """
 To Support the Seeed USB-Can analyzer interface. The device will appear
 as a serial port, for example "/dev/ttyUSB0" on Linux machines
diff --git a/can/interfaces/serial/__init__.py b/can/interfaces/serial/__init__.py
@@ -1,5 +1,3 @@
-# coding: utf-8
-
 """
 """
 
diff --git a/can/interfaces/serial/serial_can.py b/can/interfaces/serial/serial_can.py
@@ -1,5 +1,3 @@
-# coding: utf-8
-
 """
 A text based interface. For example use over serial ports like
 "/dev/ttyS1" or "/dev/ttyUSB0" on Linux machines or "COM1" on Windows.
diff --git a/can/interfaces/slcan.py b/can/interfaces/slcan.py
@@ -1,5 +1,3 @@
-# coding: utf-8
-
 """
 Interface for slcan compatible interfaces (win32/linux).
 
diff --git a/can/interfaces/socketcan/__init__.py b/can/interfaces/socketcan/__init__.py
@@ -1,5 +1,3 @@
-# coding: utf-8
-
 """
 See: https://www.kernel.org/doc/Documentation/networking/can.txt
 """
diff --git a/can/interfaces/socketcan/constants.py b/can/interfaces/socketcan/constants.py
@@ -1,5 +1,3 @@
-# coding: utf-8
-
 """
 Defines shared CAN constants.
 """
diff --git a/can/interfaces/socketcan/socketcan.py b/can/interfaces/socketcan/socketcan.py
@@ -1,5 +1,3 @@
-# coding: utf-8
-
 """
 The main module of the socketcan interface containing most user-facing classes and methods
 along some internal methods.
diff --git a/can/interfaces/socketcan/utils.py b/can/interfaces/socketcan/utils.py
@@ -1,5 +1,3 @@
-# coding: utf-8
-
 """
 Defines common socketcan functions.
 """
diff --git a/can/interfaces/systec/__init__.py b/can/interfaces/systec/__init__.py
@@ -1,5 +1,3 @@
-# coding: utf-8
-
 """
 """
 
diff --git a/can/interfaces/systec/constants.py b/can/interfaces/systec/constants.py
@@ -1,5 +1,3 @@
-# coding: utf-8
-
 from ctypes import c_ubyte as BYTE, c_ushort as WORD, c_ulong as DWORD
 
 #: Maximum number of modules that are supported.
diff --git a/can/interfaces/systec/exceptions.py b/can/interfaces/systec/exceptions.py
@@ -1,5 +1,3 @@
-# coding: utf-8
-
 from .constants import ReturnCode
 from can import CanError
 
diff --git a/can/interfaces/systec/structures.py b/can/interfaces/systec/structures.py
@@ -1,5 +1,3 @@
-# coding: utf-8
-
 from ctypes import Structure, POINTER, sizeof
 from ctypes import (
     c_ubyte as BYTE,
diff --git a/can/interfaces/systec/ucan.py b/can/interfaces/systec/ucan.py
@@ -1,5 +1,3 @@
-# coding: utf-8
-
 import logging
 import sys
 
diff --git a/can/interfaces/systec/ucanbus.py b/can/interfaces/systec/ucanbus.py
@@ -1,5 +1,3 @@
-# coding: utf-8
-
 import logging
 from threading import Event
 
diff --git a/can/interfaces/usb2can/__init__.py b/can/interfaces/usb2can/__init__.py
@@ -1,5 +1,3 @@
-# coding: utf-8
-
 """
 """
 
diff --git a/can/interfaces/usb2can/serial_selector.py b/can/interfaces/usb2can/serial_selector.py
@@ -1,5 +1,3 @@
-# coding: utf-8
-
 """
 """
 
diff --git a/can/interfaces/usb2can/usb2canInterface.py b/can/interfaces/usb2can/usb2canInterface.py
@@ -1,5 +1,3 @@
-# coding: utf-8
-
 """
 This interface is for Windows only, otherwise use socketCAN.
 """
diff --git a/can/interfaces/usb2can/usb2canabstractionlayer.py b/can/interfaces/usb2can/usb2canabstractionlayer.py
@@ -1,5 +1,3 @@
-# coding: utf-8
-
 """
 This wrapper is for windows or direct access via CANAL API.
 Socket CAN is recommended under Unix/Linux systems.
diff --git a/can/interfaces/vector/__init__.py b/can/interfaces/vector/__init__.py
@@ -1,5 +1,3 @@
-# coding: utf-8
-
 """
 """
 
diff --git a/can/interfaces/vector/canlib.py b/can/interfaces/vector/canlib.py
@@ -1,5 +1,3 @@
-# coding: utf-8
-
 """
 Ctypes wrapper module for Vector CAN Interface on win32/win64 systems.
 
diff --git a/can/interfaces/vector/exceptions.py b/can/interfaces/vector/exceptions.py
@@ -1,5 +1,3 @@
-# coding: utf-8
-
 """
 """
 
diff --git a/can/interfaces/vector/xlclass.py b/can/interfaces/vector/xlclass.py
@@ -1,5 +1,3 @@
-# coding: utf-8
-
 """
 Definition of data types and structures for vxlapi.
 
diff --git a/can/interfaces/vector/xldefine.py b/can/interfaces/vector/xldefine.py
@@ -1,5 +1,3 @@
-# coding: utf-8
-
 """
 Definition of constants for vxlapi.
 """
diff --git a/can/interfaces/vector/xldriver.py b/can/interfaces/vector/xldriver.py
@@ -1,5 +1,3 @@
-# coding: utf-8
-
 """
 Ctypes wrapper module for Vector CAN Interface on win32/win64 systems.
 
diff --git a/can/interfaces/virtual.py b/can/interfaces/virtual.py
@@ -1,5 +1,3 @@
-# coding: utf-8
-
 """
 This module implements an OS and hardware independent
 virtual CAN interface for testing purposes.
diff --git a/can/io/__init__.py b/can/io/__init__.py
@@ -1,5 +1,3 @@
-# coding: utf-8
-
 """
 Read and write CAN bus messages using a range of Readers
 and Writers based off the file extension.
diff --git a/can/io/asc.py b/can/io/asc.py
@@ -1,5 +1,3 @@
-# coding: utf-8
-
 """
 Contains handling of ASC logging files.
 
diff --git a/can/io/blf.py b/can/io/blf.py
@@ -1,5 +1,3 @@
-# coding: utf-8
-
 """
 Implements support for BLF (Binary Logging Format) which is a proprietary
 CAN log format from Vector Informatik GmbH (Germany).
diff --git a/can/io/canutils.py b/can/io/canutils.py
@@ -1,5 +1,3 @@
-# coding: utf-8
-
 """
 This module works with CAN data in ASCII log files (*.log).
 It is is compatible with "candump -L" from the canutils program
diff --git a/can/io/csv.py b/can/io/csv.py
@@ -1,5 +1,3 @@
-# coding: utf-8
-
 """
 This module contains handling for CSV (comma separated values) files.
 
diff --git a/can/io/generic.py b/can/io/generic.py
@@ -1,5 +1,3 @@
-# coding: utf-8
-
 """
 Contains a generic class for file IO.
 """
diff --git a/can/io/logger.py b/can/io/logger.py
@@ -1,5 +1,3 @@
-# coding: utf-8
-
 """
 See the :class:`Logger` class.
 """
diff --git a/can/io/player.py b/can/io/player.py
@@ -1,5 +1,3 @@
-# coding: utf-8
-
 """
 This module contains the generic :class:`LogReader` as
 well as :class:`MessageSync` which plays back messages
diff --git a/can/io/printer.py b/can/io/printer.py
@@ -1,5 +1,3 @@
-# coding: utf-8
-
 """
 This Listener simply prints to stdout / the terminal or a file.
 """
diff --git a/can/io/sqlite.py b/can/io/sqlite.py
@@ -1,5 +1,3 @@
-# coding: utf-8
-
 """
 Implements an SQL database writer and reader for storing CAN messages.
 
diff --git a/can/listener.py b/can/listener.py
@@ -1,5 +1,3 @@
-# coding: utf-8
-
 """
 This module contains the implementation of `can.Listener` and some readers.
 """
diff --git a/can/logger.py b/can/logger.py
@@ -1,5 +1,3 @@
-# coding: utf-8
-
 """
 logger.py logs CAN traffic to the terminal and to a file on disk.
 
diff --git a/can/message.py b/can/message.py
@@ -1,5 +1,3 @@
-# coding: utf-8
-
 """
 This module contains the implementation of :class:`can.Message`.
 
diff --git a/can/notifier.py b/can/notifier.py
diff --git a/can/player.py b/can/player.py
diff --git a/can/thread_safe_bus.py b/can/thread_safe_bus.py
diff --git a/can/util.py b/can/util.py
diff --git a/can/viewer.py b/can/viewer.py
diff --git a/doc/conf.py b/doc/conf.py
diff --git a/scripts/can_logger.py b/scripts/can_logger.py
diff --git a/scripts/can_player.py b/scripts/can_player.py
diff --git a/scripts/can_viewer.py b/scripts/can_viewer.py
diff --git a/setup.py b/setup.py

Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,3 @@`
`1`		`-# coding: utf-8`
`2`		`-`
`3`	`1`	`"""`
`4`	`2`	``can`` is an object-orient Controller Area Network (CAN) interface module.
`5`	`3`	`"""`
Original file line number	Diff line number	Diff line change
`@@ -1,5 +1,3 @@`
`1`		`-# coding: utf-8`
`2`		`-`
`3`	`1`	`from ctypes import *`
`4`	`2`	`import logging`
`5`	`3`	`import platform`