Skip to content

test sanity proposal#5607

Draft
quantizor wants to merge 11 commits intomainfrom
test-stipsan-pr
Draft

test sanity proposal#5607
quantizor wants to merge 11 commits intomainfrom
test-stipsan-pr

Conversation

@quantizor
Copy link
Copy Markdown
Contributor

@quantizor quantizor commented Sep 15, 2025

This is @stipsan's PR #4332 on top of my concurrency benchmark PR #5606

Best of 3

Screenshot 2025-09-14 at 11 55 52 PM

I'm just not seeing the 40%

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Sep 15, 2025

🦋 Changeset detected

Latest commit: 8c7c967

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
styled-components Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@quantizor
Copy link
Copy Markdown
Contributor Author

@stipsan I went ahead and relaid your PR changes over my updates to get the suite properly making use of React 18. At the moment I'm still seeing no real change, can you look at the benchmark and suggest any changes to make it more representative?

@stipsan
Copy link
Copy Markdown

stipsan commented Sep 16, 2025

@stipsan I went ahead and relaid your PR changes over my updates to get the suite properly making use of React 18. At the moment I'm still seeing no real change, can you look at the benchmark and suggest any changes to make it more representative?

@quantizor in order to see more representative results you need to:

  • trigger suspense interrupting render
  • do much more work during render, if the bench uses .attrs((p) => ({style: {borderBottomColor: p.$color}})) type techniques then the penalty of doing work during render that is ultimately discarded is much more apparent.

For example,

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants