Skip to content

Commit 9a8b082

Browse files
committed
Fix some compiler warnings in proxy
PR: Obtained from: Submitted by: Geoffrey Young <geoff@modperlcookbook.org> Reviewed by: git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@104708 13f79535-47bb-0310-9956-ffa450edef68
1 parent 9920fb8 commit 9a8b082

4 files changed

Lines changed: 10 additions & 2 deletions

File tree

CHANGES

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,9 @@ Changes with Apache 2.1.0-dev
22

33
[Remove entries to the current 2.0 section below, when backported]
44

5+
*) Fix some compiler warnings in proxy
6+
[Geoffrey Young <geoff@modperlcookbook.org>]
7+
58
*) suexec: Pass the SERVER_SIGNATURE envvar through to CGIs.
69
[Zvi Har'El <rl math.technion.ac.il>]
710

modules/proxy/mod_proxy.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -388,6 +388,7 @@ PROXY_DECLARE(struct proxy_balancer *) ap_proxy_get_balancer(apr_pool_t *p, prox
388388
PROXY_DECLARE(const char *) ap_proxy_add_balancer(proxy_balancer **balancer, apr_pool_t *p, proxy_server_conf *conf, const char *url);
389389
PROXY_DECLARE(void) ap_proxy_add_worker_to_balancer(apr_pool_t *pool, proxy_balancer *balancer, proxy_worker *worker);
390390
PROXY_DECLARE(int) ap_proxy_pre_request(proxy_worker **worker, proxy_balancer **balancer, request_rec *r, proxy_server_conf *conf, char **url);
391+
PROXY_DECLARE(int) ap_proxy_post_request(proxy_worker *worker, proxy_balancer *balancer, request_rec *r, proxy_server_conf *conf);
391392
PROXY_DECLARE(int) ap_proxy_determine_connection(apr_pool_t *p, request_rec *r, proxy_server_conf *conf, proxy_worker *worker, proxy_conn_rec *conn,
392393
apr_pool_t *ppool, apr_uri_t *uri, char **url, const char *proxyname, apr_port_t proxyport,
393394
char *server_portstr, int server_portstr_size);

modules/proxy/proxy_ftp.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -745,7 +745,8 @@ apr_status_t proxy_ftp_cleanup(request_rec *r, proxy_conn_rec *backend)
745745
return OK;
746746
}
747747

748-
static ftp_proxyerror(request_rec *r, proxy_conn_rec *conn, int statuscode, const char *message)
748+
static
749+
int ftp_proxyerror(request_rec *r, proxy_conn_rec *conn, int statuscode, const char *message)
749750
{
750751
proxy_ftp_cleanup(r, conn);
751752
return ap_proxyerror(r, statuscode, message);
@@ -782,7 +783,6 @@ int ap_proxy_ftp_handler(request_rec *r, proxy_worker *worker, proxy_server_conf
782783
int len, rc;
783784
int one = 1;
784785
char *size = NULL;
785-
apr_socket_t *origin_sock = NULL;
786786
char xfer_type = 'A'; /* after ftp login, the default is ASCII */
787787
int dirlisting = 0;
788788
#if defined(USE_MDTM) && (defined(HAVE_TIMEGM) || defined(HAVE_GMTOFF))

modules/proxy/proxy_util.c

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,10 @@
1919
#include "scoreboard.h"
2020
#include "apr_version.h"
2121

22+
#if APR_HAVE_UNISTD_H
23+
#include <unistd.h> /* for getpid() */
24+
#endif
25+
2226
#if (APR_MAJOR_VERSION < 1)
2327
#undef apr_socket_create
2428
#define apr_socket_create apr_socket_create_ex

0 commit comments

Comments
 (0)