Graceful handling of unfindable ApplicableList objects

pde · pde · commit f82adcbc5c67 · 2012-07-30T17:54:14.000-07:00
https://trac.torproject.org/projects/tor/ticket/6280
diff --git a/src/components/https-everywhere.js b/src/components/https-everywhere.js
@@ -431,7 +431,7 @@ HTTPSEverywhere.prototype = {
       var lst = this.getApplicableListForChannel(channel);
       if (channel.URI.spec in https_everywhere_blacklist) {
         this.log(DBUG, "Avoiding blacklisted " + channel.URI.spec);
-        lst.breaking_rule(https_everywhere_blacklist[channel.URI.spec]);
+        if (lst) lst.breaking_rule(https_everywhere_blacklist[channel.URI.spec]);
         return;
       }
       HTTPS.replaceChannel(lst, channel);

Original file line number	Diff line number	Diff line change
`@@ -431,7 +431,7 @@ HTTPSEverywhere.prototype = {`
`431`	`431`	`var lst = this.getApplicableListForChannel(channel);`
`432`	`432`	`if (channel.URI.spec in https_everywhere_blacklist) {`
`433`	`433`	`this.log(DBUG, "Avoiding blacklisted " + channel.URI.spec);`
`434`		`- lst.breaking_rule(https_everywhere_blacklist[channel.URI.spec]);`
	`434`	`+ if (lst) lst.breaking_rule(https_everywhere_blacklist[channel.URI.spec]);`
`435`	`435`	`return;`
`436`	`436`	`}`
`437`	`437`	`HTTPS.replaceChannel(lst, channel);`