test: update tests a bit (with last changes of runtime)

stringparser · stringparser · commit 8b4dfca99150 · 2016-09-18T22:25:10.000+02:00
diff --git a/test/cli.js b/test/cli.js
@@ -23,65 +23,61 @@ exports = module.exports = function (Gulp, util) {
     util.rimraf(test.dirname, done);
   });
 
-  var gulp = Gulp.create();
-
   it('--silent should turn off logging', function (done) {
-    gulp.stack('--silent', {
-      onHandleError: done,
-      onHandleEnd: function () {
-        should(this.log).be.eql(false);
-        done();
-        gulp.log = true;
-      }
-    })();
+    var gulp = Gulp.create();
+
+    gulp.log.should.be.eql(true);
+
+    gulp.start(['--silent'], function (error) {
+      if (error) { return done(error); }
+      should(gulp.log).be.eql(false);
+      done();
+    });
   });
 
   it('--no-color should turn colors off', function (done) {
-    gulp.stack('--no-color', {
-      onHandleError: done,
-      onHandleEnd: function () {
-        should(util.lib.chalk).have.property('enabled', false);
-        done();
-      }
-    })();
+    var gulp = Gulp.create();
+
+    gulp.start(['--no-color'], function (error) {
+      if (error) { return done(error); }
+      should(util.lib.chalk).have.property('enabled', false);
+      done();
+    });
   });
 
   it('--color should restore them', function (done) {
-    gulp.stack('--color', {
-      onHandleError: done,
-      onHandleEnd: function () {
-        should(util.lib.chalk).have.property('enabled', true);
-        done();
-      }
-    })();
+    var gulp = Gulp.create();
+
+    gulp.start(['--color'], function (error) {
+      if (error) { return done(error); }
+      should(util.lib.chalk).have.property('enabled', true);
+      done();
+    });
   });
 
   it('--cwd :dirname should change cwd', function (done) {
     var cwd = process.cwd();
+    var gulp = Gulp.create();
 
-    gulp.stack('--cwd ' + test.dirname, {
-      onHandleError: done,
-      onHandleEnd: function () {
-        should(process.cwd()).be.eql(test.dirname);
-        process.chdir(cwd); // restore previous working directory
-        done();
-      }
-    })();
+    gulp.start(['--cwd ' + test.dirname], function (error) {
+      if (error) { return done(error); }
+      should(process.cwd()).be.eql(test.dirname);
+      process.chdir(cwd); // restore previous working directory
+      done();
+    });
   });
 
   it('--require should require a module from the cwd', function (done) {
     var cwd = process.cwd();
+    var gulp = Gulp.create();
+
+    should(require.cache).not.have.property(test.file);
 
-    gulp.stack('--require ' + test.file, {
-      onHandleError: done,
-      onHandleStart: function () {
-        should(require.cache).not.have.property(test.file);
-      },
-      onHandleEnd: function () {
-        should(require.cache).have.property(test.file);
-        process.cwd().should.be.eql(cwd);
-        done();
-      }
-    })();
+    gulp.start(['--require ' + test.file], function (error) {
+      if (error) { return done(error); }
+      should(require.cache).have.property(test.file);
+      process.cwd().should.be.eql(cwd);
+      done();
+    });
   });
 };
diff --git a/test/create.js b/test/create.js
@@ -13,6 +13,7 @@ exports = module.exports = function (Gulp) {
 
   it('create({log: false}) should disable logging', function () {
     var gulp = Gulp.create({log: false});
+    gulp.props.log.should.be.eql(false);
     gulp.log.should.be.eql(false);
   });
 
diff --git a/test/index.js b/test/index.js
@@ -2,7 +2,6 @@
 
 require('should');
 
-
 var Gulp = require('../');
 var util = require('./util');
 
diff --git a/test/task.js b/test/task.js
@@ -1,6 +1,7 @@
 'use strict';
 
 exports = module.exports = function (Gulp) {
+  var should = require('should');
 
   it('task(name, fn) registers task `name`', function () {
     var gulp = Gulp.create();
@@ -52,7 +53,7 @@ exports = module.exports = function (Gulp) {
 
     gulp.task('taskName', deps, function () {});
     gulp.stack('taskName')(function (error) {
-      error.should.be.instanceof(Error);
+      should(error).be.instanceof(Error);
       done();
     });
   });
