RmJQuery: replace Backbone.ajax (#1453)

mockdeep · web-flow · commit 20dedfeb3a18 · 2026-03-13T13:57:11.000-07:00
diff --git a/app/javascript/application.ts b/app/javascript/application.ts
@@ -1,7 +1,6 @@
 // @ts-nocheck
 import "@hotwired/turbo-rails";
 import "@rails/activestorage";
-import "jquery";
 import * as bootstrap from "bootstrap";
 
 window.bootstrap = bootstrap;
@@ -14,12 +13,25 @@ import "./controllers/index";
 
 Turbo.session.drive = false;
 
-/* global jQuery, Mousetrap */
-var $ = jQuery;
+/* global Mousetrap */
 
-window.$ = $;
-
-Backbone.$ = $;
+Backbone.ajax = async function(options) {
+  try {
+    const response = await fetch(options.url, {
+      body: options.data,
+      headers: {"Content-Type": "application/json", ...options.headers},
+      method: options.type || "GET",
+    });
+    const data = await response.json();
+    if (response.ok && options.success) {
+      options.success(data, response.statusText, response);
+    } else if (!response.ok && options.error) {
+      options.error(response, response.statusText, null);
+    }
+  } catch (err: unknown) {
+    if (options.error) options.error(null, "error", err);
+  }
+};
 
 _.templateSettings = {
   evaluate: /\{\{(.+?)\}\}/g,
diff --git a/app/javascript/support/jquery-global.ts b/app/javascript/support/jquery-global.ts
diff --git a/bin/build b/bin/build
@@ -8,6 +8,5 @@ esbuild app/javascript/*.ts \
   --format=iife \
   --outdir=app/assets/builds \
   --public-path=/assets \
-  --alias:jquery=./app/javascript/support/jquery-global.ts \
   --alias:bootstrap=./node_modules/bootstrap/dist/js/bootstrap.bundle.js \
   "$@"
diff --git a/package.json b/package.json
@@ -13,7 +13,6 @@
     "backbone.nativeview": "^0.3.4",
     "bootstrap": "^5.3.3",
     "font-awesome": "4.7.0",
-    "jquery": "2.2.4",
     "mousetrap": "1.4.6",
     "underscore": "1.13.8"
   },
@@ -23,7 +22,6 @@
     "@stylistic/eslint-plugin": "^5.7.0",
     "@types/backbone": "latest",
     "@types/hotwired__turbo": "^8.0.5",
-    "@types/jquery": "3.5.34",
     "@types/mousetrap": "latest",
     "@types/node": "^25.2.3",
     "@types/rails__actioncable": "^8.0.3",
diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml
diff --git a/spec/javascript/setup.ts b/spec/javascript/setup.ts
@@ -1,22 +1,16 @@
 // @ts-nocheck
 /// <reference types="vitest/globals" />
 
-import "jquery";
 import underscore from "underscore";
 import Backbone from "backbone";
 
 beforeEach(() => {
   expect.hasAssertions();
 });
 
-const jquery = window.jQuery;
-globalThis.$ = jquery;
-globalThis.jQuery = jquery;
 globalThis._ = underscore;
 globalThis.Backbone = Backbone;
 
-Backbone.$ = jquery;
-
 _.templateSettings = {
   evaluate: /\{\{(.+?)\}\}/g,
   interpolate: /\{\{=(.+?)\}\}/g,
diff --git a/vitest.config.ts b/vitest.config.ts
@@ -15,7 +15,6 @@ export default defineConfig({
       {find: /^helpers\//u, replacement: appPath("helpers")},
       {find: /^javascript\//u, replacement: appPath("")},
       {find: /^spec\//u, replacement: `${path.resolve(root, "spec")}/`},
-      {find: "jquery", replacement: path.resolve(root, "app/javascript/support/jquery-global.ts")},
       {find: "bootstrap", replacement: path.resolve(root, "node_modules/bootstrap/dist/js/bootstrap.js")},
       {find: "mousetrap", replacement: path.resolve(root, "node_modules/mousetrap/mousetrap.js")},
       {

Original file line number	Diff line number	Diff line change
`@@ -15,7 +15,6 @@ export default defineConfig({`
`15`	`15`	`{find: /^helpers\//u, replacement: appPath("helpers")},`
`16`	`16`	`{find: /^javascript\//u, replacement: appPath("")},`
`17`	`17`	{find: /^spec\//u, replacement: `${path.resolve(root, "spec")}/`},
`18`		`- {find: "jquery", replacement: path.resolve(root, "app/javascript/support/jquery-global.ts")},`
`19`	`18`	`{find: "bootstrap", replacement: path.resolve(root, "node_modules/bootstrap/dist/js/bootstrap.js")},`
`20`	`19`	`{find: "mousetrap", replacement: path.resolve(root, "node_modules/mousetrap/mousetrap.js")},`
`21`	`20`	`{`