Skip to content

Commit b9f5c17

Browse files
committed
Fix link and apply some suggestions from the grammar checker.
1 parent f813a2b commit b9f5c17

5 files changed

Lines changed: 11 additions & 11 deletions

File tree

docs/code-quality/c26437.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ ms.assetid: ed2f55bc-a6d8-4cc4-8069-5c96e581a96a
1313
**C++ Core Guidelines**:
1414
[ES.63: Don't slice](https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#Res-slice)
1515

16-
[Slicing](https://en.wikipedia.org/wiki/Object_slicing) is allowed by the compiler and can be viewed as a special case of a dangerous implicit cast. Even if it's done intentionally and doesn't lead to immediate issues, it's still highly discouraged. It makes code harder to change, by forcing extra requirements on related data types. It's especially true if types are polymorphic or involve resource management.
16+
The language allows [slicing](https://en.wikipedia.org/wiki/Object_slicing) and can be viewed as a special case of a dangerous implicit cast. Even if it's done intentionally and doesn't lead to immediate issues, it's still highly discouraged. It makes code harder to change, by forcing extra requirements on related data types. It's especially true if types are polymorphic or involve resource management.
1717

1818
## Remarks
1919

@@ -44,7 +44,7 @@ bool read_id(stream &s, id &v) {
4444
}
4545
```
4646
47-
To fix the issue update the function to use the correct types:
47+
To fix the issue, update the function to use the correct types:
4848
4949
```cpp
5050
// ...

docs/code-quality/c26439.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ ms.assetid: 9df2a1b0-ea94-4884-9d28-c1522ec33a1b
1414

1515
Some kinds of operations should never throw exceptions. Their implementations should be reliable and should handle possible errors conditions gracefully. They should never use exceptions to indicate failure. This rule flags cases where such operations aren't explicitly marked as `noexcept`, which means that they may throw exceptions and can't convey assumptions about their reliability.
1616

17-
It is important for these operations to be reliable as they are often used to implement operations with certain [exception safety guarantees](https://en.cppreference.com/w/cpp/language/exceptions). A throwing move constructor could also force STL containers to fall back to copy operations and reduce the runtime performance.
17+
It's important for these operations to be reliable as they're often used to implement operations with certain [exception safety guarantees](https://en.cppreference.com/w/cpp/language/exceptions). A throwing move constructor could also force STL containers to fall back to copy operations and reduce the runtime performance.
1818

1919
Code analysis name: `SPECIAL_NOEXCEPT`
2020

@@ -25,13 +25,13 @@ Code analysis name: `SPECIAL_NOEXCEPT`
2525
- move constructors and move assignment operators;
2626
- standard functions with move semantics: `std::move` and `std::swap`.
2727

28-
- Non-standard and outdated specifiers like `throw()` or `declspec(nothrow)` aren't equivalent to `noexcept`.
28+
- Nonstandard and outdated specifiers like `throw()` or `declspec(nothrow)` aren't equivalent to `noexcept`.
2929

3030
- Explicit specifiers `noexcept(false)` and `noexcept(true)` are respected appropriately.
3131

3232
## Example
3333

34-
All functions except the destructor will warn because they're missing noexcept.
34+
The tool warns on all functions except the destructor because they're missing noexcept.
3535

3636
```cpp
3737
struct S
@@ -63,5 +63,5 @@ struct S
6363

6464
## See also
6565

66-
[C26455](./c26455)\
66+
[C26455](./c26455.md)\
6767
[**C++ Core Guidelines** F.6](https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#Rf-noexcept)

docs/code-quality/c26455.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,5 +23,5 @@ Code analysis name: `DEFAULT_CTOR_NOEXCEPT`
2323

2424
## See also
2525

26-
[C26439](./c26439)\
26+
[C26439](./c26439.md)\
2727
[**C++ Core Guidelines** F.6](https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#Rf-noexcept)

docs/code-quality/c26498.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ void foo()
3737
}
3838
```
3939

40-
To fix the issues mark the flagged variables **`constexpr`**:
40+
To fix the issues, mark the flagged variables **`constexpr`**:
4141

4242
```cpp
4343
constexpr int getMyValue()

docs/code-quality/c26800.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ helpviewer_keywords: ["C26800"]
1111
1212
## Remarks
1313

14-
Warning C26800 is triggered when variable is used after it has been moved from. A variable is considered moved from after it was passed to a function as rvalue reference. There are some legitimate exceptions for uses such as assignment, destruction, and some state resetting functions such as `std::vector::clear`. After using a state resetting function, we are free to use the variable. This check only reasons about the local variables.
14+
Warning C26800 is triggered when variable is used after it has been moved from. A variable is considered moved from after it was passed to a function as rvalue reference. There are some legitimate exceptions for uses such as assignment, destruction, and some state resetting functions such as `std::vector::clear`. After using a state resetting function, we're free to use the variable. This check only reasons about the local variables.
1515

1616
The following methods are considered state resetting methods:
1717
- Functions with the following substring in their name (not considering case sensitivity): "clear", "clean", "reset", "free", "destroy", "release", "dealloc", "assign"
@@ -46,7 +46,7 @@ Code analysis name: `USE_OF_A_MOVED_FROM_OBJECT`
4646

4747
## Examples
4848

49-
The following code will generate C26800.
49+
The following code generates C26800.
5050

5151
```cpp
5252
#include <utility>
@@ -70,7 +70,7 @@ void test() {
7070
}
7171
```
7272
73-
The following code won't generate C26800.
73+
The following code doesn't generate C26800.
7474
7575
```cpp
7676
#include <utility>

0 commit comments

Comments
 (0)