fixed always true condition

staabm · staabm · commit 84373ab2bfa1 · 2019-03-15T09:34:29.000+01:00
------ ---------------------------------
  Line   Client.php
 ------ ---------------------------------
  362    Left side of &amp;&amp; is always true.
  370    If condition is always true.
diff --git a/src/Client.php b/src/Client.php
@@ -359,17 +359,15 @@ public function readFrame()
     public function disconnect($sync = false)
     {
         try {
-            if ($this->connection && $this->connection->isConnected()) {
+            if ($this->connection->isConnected()) {
                 if ($this->protocol) {
                     $this->sendFrame($this->protocol->getDisconnectFrame(), $sync);
                 }
             }
         } catch (StompException $ex) {
             // nothing!
         }
-        if ($this->connection) {
-            $this->connection->disconnect();
-        }
+        $this->connection->disconnect();
 
         $this->sessionId = null;
         $this->unprocessedFrames = [];

Original file line number	Diff line number	Diff line change
`@@ -359,17 +359,15 @@ public function readFrame()`
`359`	`359`	`public function disconnect($sync = false)`
`360`	`360`	`{`
`361`	`361`	`try {`
`362`		`- if ($this->connection && $this->connection->isConnected()) {`
	`362`	`+ if ($this->connection->isConnected()) {`
`363`	`363`	`if ($this->protocol) {`
`364`	`364`	`$this->sendFrame($this->protocol->getDisconnectFrame(), $sync);`
`365`	`365`	`}`
`366`	`366`	`}`
`367`	`367`	`} catch (StompException $ex) {`
`368`	`368`	`// nothing!`
`369`	`369`	`}`
`370`		`- if ($this->connection) {`
`371`		`- $this->connection->disconnect();`
`372`		`- }`
	`370`	`+ $this->connection->disconnect();`
`373`	`371`
`374`	`372`	`$this->sessionId = null;`
`375`	`373`	`$this->unprocessedFrames = [];`