Skip to content

Commit 2ac1b04

Browse files
youknowoneyouknowone
committed
Upgrade nt_path from v3.14.2
1 parent 448658e commit 2ac1b04

3 files changed

Lines changed: 79 additions & 102 deletions

File tree

‎Lib/ntpath.py‎

Lines changed: 41 additions & 85 deletions
Original file line numberDiff line numberDiff line change
@@ -400,17 +400,23 @@ def expanduser(path):
400400
# XXX With COMMAND.COM you can use any characters in a variable name,
401401
# XXX except '^|<>='.
402402

403+
_varpattern = r"'[^']*'?|%(%|[^%]*%?)|\$(\$|[-\w]+|\{[^}]*\}?)"
404+
_varsub = None
405+
_varsubb = None
406+
403407
def expandvars(path):
404408
"""Expand shell variables of the forms $var, ${var} and %var%.
405409
406410
Unknown variables are left unchanged."""
407411
path = os.fspath(path)
412+
global _varsub, _varsubb
408413
if isinstance(path, bytes):
409414
if b'$' not in path and b'%' not in path:
410415
return path
411-
import string
412-
varchars = bytes(string.ascii_letters + string.digits + '_-', 'ascii')
413-
quote = b'\''
416+
if not _varsubb:
417+
import re
418+
_varsubb = re.compile(_varpattern.encode(), re.ASCII).sub
419+
sub = _varsubb
414420
percent = b'%'
415421
brace = b'{'
416422
rbrace = b'}'
@@ -419,94 +425,44 @@ def expandvars(path):
419425
else:
420426
if '$' not in path and '%' not in path:
421427
return path
422-
import string
423-
varchars = string.ascii_letters + string.digits + '_-'
424-
quote = '\''
428+
if not _varsub:
429+
import re
430+
_varsub = re.compile(_varpattern, re.ASCII).sub
431+
sub = _varsub
425432
percent = '%'
426433
brace = '{'
427434
rbrace = '}'
428435
dollar = '$'
429436
environ = os.environ
430-
res = path[:0]
431-
index = 0
432-
pathlen = len(path)
433-
while index < pathlen:
434-
c = path[index:index+1]
435-
if c == quote: # no expansion within single quotes
436-
path = path[index + 1:]
437-
pathlen = len(path)
438-
try:
439-
index = path.index(c)
440-
res += c + path[:index + 1]
441-
except ValueError:
442-
res += c + path
443-
index = pathlen - 1
444-
elif c == percent: # variable or '%'
445-
if path[index + 1:index + 2] == percent:
446-
res += c
447-
index += 1
448-
else:
449-
path = path[index+1:]
450-
pathlen = len(path)
451-
try:
452-
index = path.index(percent)
453-
except ValueError:
454-
res += percent + path
455-
index = pathlen - 1
456-
else:
457-
var = path[:index]
458-
try:
459-
if environ is None:
460-
value = os.fsencode(os.environ[os.fsdecode(var)])
461-
else:
462-
value = environ[var]
463-
except KeyError:
464-
value = percent + var + percent
465-
res += value
466-
elif c == dollar: # variable or '$$'
467-
if path[index + 1:index + 2] == dollar:
468-
res += c
469-
index += 1
470-
elif path[index + 1:index + 2] == brace:
471-
path = path[index+2:]
472-
pathlen = len(path)
473-
try:
474-
index = path.index(rbrace)
475-
except ValueError:
476-
res += dollar + brace + path
477-
index = pathlen - 1
478-
else:
479-
var = path[:index]
480-
try:
481-
if environ is None:
482-
value = os.fsencode(os.environ[os.fsdecode(var)])
483-
else:
484-
value = environ[var]
485-
except KeyError:
486-
value = dollar + brace + var + rbrace
487-
res += value
488-
else:
489-
var = path[:0]
490-
index += 1
491-
c = path[index:index + 1]
492-
while c and c in varchars:
493-
var += c
494-
index += 1
495-
c = path[index:index + 1]
496-
try:
497-
if environ is None:
498-
value = os.fsencode(os.environ[os.fsdecode(var)])
499-
else:
500-
value = environ[var]
501-
except KeyError:
502-
value = dollar + var
503-
res += value
504-
if c:
505-
index -= 1
437+
438+
def repl(m):
439+
lastindex = m.lastindex
440+
if lastindex is None:
441+
return m[0]
442+
name = m[lastindex]
443+
if lastindex == 1:
444+
if name == percent:
445+
return name
446+
if not name.endswith(percent):
447+
return m[0]
448+
name = name[:-1]
506449
else:
507-
res += c
508-
index += 1
509-
return res
450+
if name == dollar:
451+
return name
452+
if name.startswith(brace):
453+
if not name.endswith(rbrace):
454+
return m[0]
455+
name = name[1:-1]
456+
457+
try:
458+
if environ is None:
459+
return os.fsencode(os.environ[os.fsdecode(name)])
460+
else:
461+
return environ[name]
462+
except KeyError:
463+
return m[0]
464+
465+
return sub(repl, path)
510466

511467

512468
# Normalize a path, e.g. A//B, A/./B and A/foo/../B all become A\B.

‎Lib/test/test_genericpath.py‎

Lines changed: 20 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -7,9 +7,9 @@
77
import sys
88
import unittest
99
import warnings
10-
from test.support import (
11-
is_apple, is_emscripten, os_helper, warnings_helper
12-
)
10+
from test import support
11+
from test.support import os_helper
12+
from test.support import warnings_helper
1313
from test.support.script_helper import assert_python_ok
1414
from test.support.os_helper import FakePath
1515

@@ -92,8 +92,8 @@ def test_commonprefix(self):
9292
for s1 in testlist:
9393
for s2 in testlist:
9494
p = commonprefix([s1, s2])
95-
self.assertTrue(s1.startswith(p))
96-
self.assertTrue(s2.startswith(p))
95+
self.assertStartsWith(s1, p)
96+
self.assertStartsWith(s2, p)
9797
if s1 != s2:
9898
n = len(p)
9999
self.assertNotEqual(s1[n:n+1], s2[n:n+1])
@@ -161,7 +161,6 @@ def test_exists(self):
161161
self.assertIs(self.pathmodule.lexists(path=filename), True)
162162

163163
@unittest.skipUnless(hasattr(os, "pipe"), "requires os.pipe()")
164-
@unittest.skipIf(is_emscripten, "Emscripten pipe fds have no stat")
165164
def test_exists_fd(self):
166165
r, w = os.pipe()
167166
try:
@@ -171,8 +170,7 @@ def test_exists_fd(self):
171170
os.close(w)
172171
self.assertFalse(self.pathmodule.exists(r))
173172

174-
# TODO: RUSTPYTHON
175-
@unittest.expectedFailure
173+
@unittest.expectedFailure # TODO: RUSTPYTHON
176174
def test_exists_bool(self):
177175
for fd in False, True:
178176
with self.assertWarnsRegex(RuntimeWarning,
@@ -352,7 +350,6 @@ def test_invalid_paths(self):
352350
with self.assertRaisesRegex(ValueError, 'embedded null'):
353351
func(b'/tmp\x00abcds')
354352

355-
356353
# Following TestCase is not supposed to be run from test_genericpath.
357354
# It is inherited by other test modules (ntpath, posixpath).
358355

@@ -449,6 +446,19 @@ def check(value, expected):
449446
os.fsencode('$bar%s bar' % nonascii))
450447
check(b'$spam}bar', os.fsencode('%s}bar' % nonascii))
451448

449+
@support.requires_resource('cpu')
450+
def test_expandvars_large(self):
451+
expandvars = self.pathmodule.expandvars
452+
with os_helper.EnvironmentVarGuard() as env:
453+
env.clear()
454+
env["A"] = "B"
455+
n = 100_000
456+
self.assertEqual(expandvars('$A'*n), 'B'*n)
457+
self.assertEqual(expandvars('${A}'*n), 'B'*n)
458+
self.assertEqual(expandvars('$A!'*n), 'B!'*n)
459+
self.assertEqual(expandvars('${A}A'*n), 'BA'*n)
460+
self.assertEqual(expandvars('${'*10*n), '${'*10*n)
461+
452462
def test_abspath(self):
453463
self.assertIn("foo", self.pathmodule.abspath("foo"))
454464
with warnings.catch_warnings():
@@ -506,7 +516,7 @@ def test_nonascii_abspath(self):
506516
# directory (when the bytes name is used).
507517
and sys.platform not in {
508518
"win32", "emscripten", "wasi"
509-
} and not is_apple
519+
} and not support.is_apple
510520
):
511521
name = os_helper.TESTFN_UNDECODABLE
512522
elif os_helper.TESTFN_NONASCII:

‎Lib/test/test_ntpath.py‎

Lines changed: 18 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -6,10 +6,9 @@
66
import sys
77
import unittest
88
import warnings
9-
from ntpath import ALLOW_MISSING
109
from test import support
11-
from test.support import cpython_only, os_helper
12-
from test.support import TestFailed, is_emscripten
10+
from test.support import os_helper
11+
from ntpath import ALLOW_MISSING
1312
from test.support.os_helper import FakePath
1413
from test import test_genericpath
1514
from tempfile import TemporaryFile
@@ -59,7 +58,7 @@ def tester(fn, wantResult):
5958
fn = fn.replace("\\", "\\\\")
6059
gotResult = eval(fn)
6160
if wantResult != gotResult and _norm(wantResult) != _norm(gotResult):
62-
raise TestFailed("%s should return: %s but returned: %s" \
61+
raise support.TestFailed("%s should return: %s but returned: %s" \
6362
%(str(fn), str(wantResult), str(gotResult)))
6463

6564
# then with bytes
@@ -75,7 +74,7 @@ def tester(fn, wantResult):
7574
warnings.simplefilter("ignore", DeprecationWarning)
7675
gotResult = eval(fn)
7776
if _norm(wantResult) != _norm(gotResult):
78-
raise TestFailed("%s should return: %s but returned: %s" \
77+
raise support.TestFailed("%s should return: %s but returned: %s" \
7978
%(str(fn), str(wantResult), repr(gotResult)))
8079

8180

@@ -1022,6 +1021,19 @@ def check(value, expected):
10221021
check('%spam%bar', '%sbar' % nonascii)
10231022
check('%{}%bar'.format(nonascii), 'ham%sbar' % nonascii)
10241023

1024+
@support.requires_resource('cpu')
1025+
def test_expandvars_large(self):
1026+
expandvars = ntpath.expandvars
1027+
with os_helper.EnvironmentVarGuard() as env:
1028+
env.clear()
1029+
env["A"] = "B"
1030+
n = 100_000
1031+
self.assertEqual(expandvars('%A%'*n), 'B'*n)
1032+
self.assertEqual(expandvars('%A%A'*n), 'BA'*n)
1033+
self.assertEqual(expandvars("''"*n + '%%'), "''"*n + '%')
1034+
self.assertEqual(expandvars("%%"*n), "%"*n)
1035+
self.assertEqual(expandvars("$$"*n), "$"*n)
1036+
10251037
def test_expanduser(self):
10261038
tester('ntpath.expanduser("test")', 'test')
10271039

@@ -1229,7 +1241,6 @@ def check_error(paths, expected):
12291241
self.assertRaises(TypeError, ntpath.commonpath, ['C:\\Foo', b'Foo\\Baz'])
12301242
self.assertRaises(TypeError, ntpath.commonpath, ['Foo', b'C:\\Foo\\Baz'])
12311243

1232-
@unittest.skipIf(is_emscripten, "Emscripten cannot fstat unnamed files.")
12331244
def test_sameopenfile(self):
12341245
with TemporaryFile() as tf1, TemporaryFile() as tf2:
12351246
# Make sure the same file is really the same
@@ -1440,7 +1451,7 @@ def test_con_device(self):
14401451
self.assertTrue(os.path.exists(r"\\.\CON"))
14411452

14421453
@unittest.skipIf(sys.platform != 'win32', "Fast paths are only for win32")
1443-
@cpython_only
1454+
@support.cpython_only
14441455
def test_fast_paths_in_use(self):
14451456
# There are fast paths of these functions implemented in posixmodule.c.
14461457
# Confirm that they are being used, and not the Python fallbacks in

0 commit comments

Comments
 (0)