refactor: perform expliict dtype argument validation

kgryte · kgryte · commit b85a1da40b6e · 2026-03-29T17:30:24.000-07:00
---
type: pre_commit_static_analysis_report
description: Results of running static analysis checks when committing changes.
report:
  - task: lint_filenames
    status: passed
  - task: lint_editorconfig
    status: passed
  - task: lint_markdown
    status: na
  - task: lint_package_json
    status: na
  - task: lint_repl_help
    status: na
  - task: lint_javascript_src
    status: passed
  - task: lint_javascript_cli
    status: na
  - task: lint_javascript_examples
    status: na
  - task: lint_javascript_tests
    status: na
  - task: lint_javascript_benchmarks
    status: na
  - task: lint_python
    status: na
  - task: lint_r
    status: na
  - task: lint_c_src
    status: na
  - task: lint_c_examples
    status: na
  - task: lint_c_benchmarks
    status: na
  - task: lint_c_tests_fixtures
    status: na
  - task: lint_shell
    status: na
  - task: lint_typescript_declarations
    status: passed
  - task: lint_typescript_tests
    status: na
  - task: lint_license_headers
    status: passed
---
diff --git a/lib/node_modules/@stdlib/array/zeros/lib/main.js b/lib/node_modules/@stdlib/array/zeros/lib/main.js
@@ -20,16 +20,21 @@
 
 // MODULES //
 
+var contains = require( '@stdlib/array/base/assert/contains' ).factory;
 var isNonNegativeInteger = require( '@stdlib/assert/is-nonnegative-integer' ).isPrimitive;
 var ctors = require( '@stdlib/array/ctors' );
 var gzeros = require( '@stdlib/array/base/zeros' );
+var dtypes = require( '@stdlib/array/dtypes' );
 var defaults = require( '@stdlib/array/defaults' );
+var join = require( '@stdlib/array/base/join' );
 var format = require( '@stdlib/string/format' );
 
 
 // VARIABLES //
 
 var DEFAULT_DTYPE = defaults.get( 'dtypes.default' );
+var DTYPES = dtypes( 'numeric_and_generic' );
+var isValidDType = contains( DTYPES );
 
 
 // MAIN //
@@ -59,6 +64,9 @@ function zeros( length ) {
 	}
 	if ( arguments.length > 1 ) {
 		dtype = arguments[ 1 ];
+		if ( !isValidDType( dtype ) ) {
+			throw new TypeError( format( 'invalid argument. Second argument must be one of the following: "%s". Value: `%s`.', join( DTYPES, '", "' ), dtype ) );
+		}
 	} else {
 		dtype = DEFAULT_DTYPE;
 	}
