[[ Bug 22761 ]] Fix Android mobile player controller visibility

montegoulding · montegoulding · commit e7bb058c2132 · 2020-04-13T11:19:28.000+10:00
This patch ensures that the mobile player controller is not visible when the
mobile player is invisible. This fixes an issue where setting the showController
property to true would show the controller regardless of the visibility of the
player.
diff --git a/docs/notes/bugfix-22671.md b/docs/notes/bugfix-22671.md
@@ -0,0 +1 @@
+# Ensure Android mobile player controller is not visible when the control is not visible
diff --git a/engine/src/java/com/runrev/android/nativecontrol/VideoControl.java b/engine/src/java/com/runrev/android/nativecontrol/VideoControl.java
@@ -159,7 +159,10 @@ public boolean setFile(String path, boolean isAsset)
     public void setShowController(boolean show)
     {
         if (show)
+		{
             m_video_view.setMediaController(m_video_controller);
+			m_video_view.setControllerVisible(getVisible());
+		}
         else
             m_video_view.setMediaController(null);
     }

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	`+# Ensure Android mobile player controller is not visible when the control is not visible`
Original file line number	Diff line number	Diff line change
`@@ -159,7 +159,10 @@ public boolean setFile(String path, boolean isAsset)`
`159`	`159`	`public void setShowController(boolean show)`
`160`	`160`	`{`
`161`	`161`	`if (show)`
	`162`	`+ {`
`162`	`163`	`m_video_view.setMediaController(m_video_controller);`
	`164`	`+ m_video_view.setControllerVisible(getVisible());`
	`165`	`+ }`
`163`	`166`	`else`
`164`	`167`	`m_video_view.setMediaController(null);`
`165`	`168`	`}`