src: guard against double free in randomBytes()

bnoordhuis · bnoordhuis · commit ed2a7fbcfec6 · 2017-07-17T23:09:48.000+02:00
PR-URL: nodejs#14122 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com>
diff --git a/src/node_crypto.cc b/src/node_crypto.cc
@@ -5498,6 +5498,7 @@ class RandomBytesRequest : public AsyncWrap {
     size_ = 0;
     if (free_mode_ == FREE_DATA) {
       free(data_);
+      data_ = nullptr;
     }
   }
 

Original file line number	Diff line number	Diff line change
`@@ -5498,6 +5498,7 @@ class RandomBytesRequest : public AsyncWrap {`
`5498`	`5498`	`size_ = 0;`
`5499`	`5499`	`if (free_mode_ == FREE_DATA) {`
`5500`	`5500`	`free(data_);`
	`5501`	`+ data_ = nullptr;`
`5501`	`5502`	`}`
`5502`	`5503`	`}`
`5503`	`5504`