Skip to content

Commit d1f7c96

Browse files
committed
test: make flaky pummel test more reliable
Increase the number of iterations from 1e4 to 1e5. Makes the test pass for me locally when previously it would fail 9 out of 10 times because the running time was not enough to smooth away the outliers. Fixes: nodejs#8744 PR-URL: nodejs#9241 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: not-an-aardvark <not-an-aardvark@users.noreply.github.com>
1 parent 1b8fca1 commit d1f7c96

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

test/pummel/test-crypto-timing-safe-equal-benchmarks.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ function runOneBenchmark(...args) {
2828
}
2929

3030
function getTValue(compareFunc) {
31-
const numTrials = 10000;
31+
const numTrials = 1e5;
3232
const bufSize = 10000;
3333
// Perform benchmarks to verify that timingSafeEqual is actually timing-safe.
3434

0 commit comments

Comments
 (0)