crypto: fix excessive buffer allocation

indutny · indutny · commit 56d9c48573e4 · 2013-06-14T17:10:04.000+02:00
Allocate buffer only if the next one isn't free.
diff --git a/src/node_crypto_bio.cc b/src/node_crypto_bio.cc
@@ -303,18 +303,26 @@ void NodeBIO::Write(const char* data, size_t size) {
 
     // Go to next buffer if there still are some bytes to write
     if (left != 0) {
-      if (write_head_->write_pos_ == kBufferLength) {
-        Buffer* next = new Buffer();
-        next->next_ = write_head_->next_;
-        write_head_->next_ = next;
-      }
+      TryAllocateForWrite();
       write_head_ = write_head_->next_;
     }
   }
   assert(left == 0);
 }
 
 
+void NodeBIO::TryAllocateForWrite() {
+  // If write head is full, next buffer is either read head or not empty.
+  if (write_head_->write_pos_ == kBufferLength &&
+      (write_head_->next_ == read_head_ ||
+       write_head_->next_->write_pos_ != 0)) {
+    Buffer* next = new Buffer();
+    next->next_ = write_head_->next_;
+    write_head_->next_ = next;
+  }
+}
+
+
 void NodeBIO::Reset() {
   while (read_head_->read_pos_ != read_head_->write_pos_) {
     assert(read_head_->write_pos_ > read_head_->read_pos_);
diff --git a/src/node_crypto_bio.h b/src/node_crypto_bio.h
@@ -59,6 +59,9 @@ class NodeBIO {
 
   ~NodeBIO();
 
+  // Allocate new buffer for write if needed
+  void TryAllocateForWrite();
+
   // Read `len` bytes maximum into `out`, return actual number of read bytes
   size_t Read(char* out, size_t size);
 
