ROX-32714: Update groovy tests for ImageV2#19972
Draft
charmik-redhat wants to merge 1 commit intomasterfrom
Draft
ROX-32714: Update groovy tests for ImageV2#19972charmik-redhat wants to merge 1 commit intomasterfrom
charmik-redhat wants to merge 1 commit intomasterfrom
Conversation
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
Skipping CI for Draft Pull Request. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #19972 +/- ##
=======================================
Coverage 49.56% 49.56%
=======================================
Files 2764 2764
Lines 208442 208442
=======================================
Hits 103321 103321
Misses 97466 97466
Partials 7655 7655
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
🚀 Build Images ReadyImages are ready for commit 5ed9a17. To use with deploy scripts: export MAIN_IMAGE_TAG=4.11.x-637-g5ed9a178aa |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Update groovy E2E tests under
qa-tests-backend/to work correctly whenFlattenImageDatais enabled (ImageV2).When
FlattenImageDatais enabled, images are stored in a newimages_v2table and their IDs change from the image digest (SHA) to a deterministic
UUIDv5 derived from the full image name and digest. These changes update
the tests to handle both ID schemes:
Helpers.generateImageV2ID()andnewV5FromNonUUIDs()to mirror theGo-side
pkg/images/utils.NewImageV2IDUUID generation logicflattenImageDataEnabledflag toBaseSpecification(read fromROX_FLATTEN_IMAGE_DATAenv var) and a pre-computedTEST_IMAGE_V2_IDAdmissionControllerTest,ImageManagementTest, andCSVTesttouse the V2 image ID when the flag is enabled
VulnMgmtTestto pass image name alongside digest so it cancompute the correct image ID for GraphQL queries
SACTestto expect an additional search result (IMAGES_V2 category)GlobalSearchto include theIMAGES_V2search categoryUpgradesTestforgetImagesand GraphQL queries,since the reprocessor may take time to migrate images to
images_v2after an upgrade
User-facing documentation
Testing and quality
Automated testing
How I validated my change
Ran tests with and without the FlattenImageData enabled